[goecharger] Fix command sending #14494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
|
Hello together, I just can confirm @DeJe63 Bugfix - I was debugging the binding and found the same issue. schogit |
|
Change looks good to me. Edit: considering the name of the branch, I assume you edited the file directly from Github. |
lolodomo
approved these changes
Feb 26, 2023
|
As this is only 2 lines added and before the fix is obvious, I am merging even if the PR is not properly signed off. |
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
miloit
pushed a commit
to miloit/openhab-addons
that referenced
this pull request
Mar 10, 2023
Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was missing "break" preventing commands to be sent correctly.