[ecobee] Increase temperature precision to decimal #14517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilbush
reviewed
Mar 1, 2023
...ab.binding.ecobee/src/main/java/org/openhab/binding/ecobee/internal/handler/EcobeeUtils.java
Outdated
Show resolved
Hide resolved
mhilbush
reviewed
Mar 1, 2023
|
You still have to apply spotless, to fix the failing build. |
When spotless is applied and DCO is fixed, we can merge. @darthbevis, can you also rename the PR title to summarize the user-experienced improvement in a few words? |
Correcting rounding of setHold values so we have 0.1°F tolerance instead of 1°F. Makes it easier to use in °C Signed-off-by: darthbevis <darthbevis@gmail.com>
Signed-off-by: darthbevis <darthbevis@gmail.com>
darthbevis
force-pushed
the
setHoldRoundingFix
branch
from
e195499 to
8026ca5
Compare
darthbevis
changed the title
|
May i suggest a hsorter title for the release notes?: |
darthbevis
changed the title
miloit
pushed a commit
to miloit/openhab-addons
that referenced
this pull request
Mar 10, 2023
* Update EcobeeUtils.java Correcting rounding of setHold values so we have 0.1°F tolerance instead of 1°F. Makes it easier to use in °C Signed-off-by: darthbevis <darthbevis@gmail.com> Signed-off-by: miloit <MichaelLoercher@web.de>
miloit
pushed a commit
to miloit/openhab-addons
that referenced
this pull request
Mar 10, 2023
* Update EcobeeUtils.java Correcting rounding of setHold values so we have 0.1°F tolerance instead of 1°F. Makes it easier to use in °C Signed-off-by: darthbevis <darthbevis@gmail.com> Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Update EcobeeUtils.java Correcting rounding of setHold values so we have 0.1°F tolerance instead of 1°F. Makes it easier to use in °C Signed-off-by: darthbevis <darthbevis@gmail.com>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* Update EcobeeUtils.java Correcting rounding of setHold values so we have 0.1°F tolerance instead of 1°F. Makes it easier to use in °C Signed-off-by: darthbevis <darthbevis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting rounding of setHold values so we have 0.1°F tolerance instead of 1°F. Makes it easier to use in °C
Signed-off-by: Bevan Watkiss darthbevis@gmail.com