Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jrubyscripting] Filter files that are added to the watch list #14590

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 12, 2023

Depends on openhab/openhab-core#3451
The original NPE bug is fixed entirely within openhab/openhab-core#3451 so this PR no longer depends on it.

Somewhat related though is to filter the file types that are added to the watch list, so that the filewatcher won't try to load files with other extensions within the automation/ruby (sub)directory.

@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on awaiting other PR Depends on another PR labels Mar 12, 2023
@jimtng jimtng force-pushed the jruby-npe branch 2 times, most recently from ede64c7 to a452bf8 Compare March 14, 2023 22:33
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng changed the title [jrubyscripting] Fix NPE caused by AbstractScriptFileWatcher initialization [jrubyscripting] Filter files that are added to the watch list Mar 14, 2023
@jlaur jlaur removed the awaiting other PR Depends on another PR label Mar 15, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 72254b8 into openhab:main Mar 21, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 21, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@jimtng jimtng deleted the jruby-npe branch August 16, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants