Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Declare connection #14684

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Mar 26, 2023

Related to #14885

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Copy link
Contributor Author

jlaur commented Mar 26, 2023

@wborn - it seems this one triggered a full Jenkins build, do you have any idea why? It did not happen for #14683 which is very similar.

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 26, 2023
@andrewfg
Copy link
Contributor

andrewfg commented Mar 26, 2023

@jlaur to be honest I don't really know what the 'connection' xml element even means. ??

.. does it indicate if the binding uses a LAN based API resp. a Cloud based one ??

Anyway LGTM :)

Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn
Copy link
Member

wborn commented Mar 26, 2023

The Jenkins job was updated similar to #14680. But apparently it was not looking in the correct workspace dir for the existence of the add-on bundle which has now been corrected!

@wborn wborn merged commit 1726031 into openhab:main Mar 26, 2023
@wborn wborn added this to the 4.0 milestone Mar 26, 2023
@jlaur
Copy link
Contributor Author

jlaur commented Mar 26, 2023

to be honest I don't really know what the 'connection' xml element even means. ??

See openhab/openhab-core#2058.

.. does it indicate if the binding uses a LAN based API resp. a Cloud based one ??

Exactly.

@jlaur jlaur deleted the hdpowerview-addon-connection branch March 26, 2023 19:25
@andrewfg
Copy link
Contributor

@jlaur ok thanks. I guess I need to add this to a few more of the bindings where I am involved. For the avoidance of doubt is the ‘category’ the same as the category for channels? Or is it just a more generic text tag?

@jlaur
Copy link
Contributor Author

jlaur commented Mar 27, 2023

For the avoidance of doubt is the ‘category’ the same as the category for channels? Or is it just a more generic text tag?

I don't think I understand the question. 🙂 If you mean if declared connection is similar to category for channels, then probably no. It more or less declares per binding if there is a dependency to external services. I don't know yet how it will be used, but could imagine filtering or even grouping. I guess you would need to ask creator of the issue if you would like to know more about the intentions and perhaps plans. In any case, to unlock the possible use cases, first we need to declare this in as many bindings as possible.

@andrewfg
Copy link
Contributor

@jlaur I was referring to the following.. (keywords / categories)..

keywords - optional but recommended - Keywords (categories) out of an open list to filter against, e.g. "heating, lighting, graphing"

@andrewfg
Copy link
Contributor

See #14690 ..

FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants