-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdpowerview] Declare connection #14684
Conversation
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur to be honest I don't really know what the 'connection' xml element even means. ?? .. does it indicate if the binding uses a LAN based API resp. a Cloud based one ?? Anyway LGTM :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Jenkins job was updated similar to #14680. But apparently it was not looking in the correct workspace dir for the existence of the add-on bundle which has now been corrected! |
See openhab/openhab-core#2058.
Exactly. |
@jlaur ok thanks. I guess I need to add this to a few more of the bindings where I am involved. For the avoidance of doubt is the ‘category’ the same as the category for channels? Or is it just a more generic text tag? |
I don't think I understand the question. 🙂 If you mean if declared connection is similar to category for channels, then probably no. It more or less declares per binding if there is a dependency to external services. I don't know yet how it will be used, but could imagine filtering or even grouping. I guess you would need to ask creator of the issue if you would like to know more about the intentions and perhaps plans. In any case, to unlock the possible use cases, first we need to declare this in as many bindings as possible. |
@jlaur I was referring to the following.. (keywords / categories)..
|
See #14690 .. |
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Related to #14885