-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more connection details to add-ons #14813
Conversation
Signed-off-by: Wouter Born <github@maindrain.net>
I did wonder if we want to use a |
See also #14776 (comment) where we lack a clear definition for "hybrid" bindings running locally, but with some cloud extensions. Perhaps for this particular case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through this many bindings and adding metadata!
I also think a |
bundles/org.openhab.voice.mimictts/src/main/resources/OH-INF/addon/addon.xml
Show resolved
Hide resolved
@@ -6,5 +6,6 @@ | |||
<type>binding</type> | |||
<name>Remote openHAB Binding</name> | |||
<description>The Remote openHAB binding allows to communicate with remote openHAB servers.</description> | |||
<connection>local</connection> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be discussed.
Yes it is local if your remote server is in the same network as your OH server but it would be cloud and you need an internet access in case you "connect" to a remote OH server not in the same local network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to post a similar comment when first seeing this, but decided not to. It's an interesting case, but also gets kind of philosophical - what does cloud really mean? You could put any device outside your own network, even on the internet, but that doesn't make it cloud. To me "cloud" means "a service on the internet completely outside of my control", but that's probably opinionated. If it just means "a service on the internet", then we are back to the problem that anything can be put on the internet, so how do we distinguish? I could also expose a local service on the internet to a friend, which would be local for me, but "cloud" to him. 🙂
In this case, maybe we should look at the most common use-case. I don't know what that is, but might be a means of migrating to a new openHAB version while still running an older version alongside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, maybe we should look at the most common use-case.
I would go with that because you can also put your serial devices in the cloud and connect to them using a rfc2217 connection provided by the serial transport. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe a common case could be that a user owns a secondary house and wants to monitor it with its main house.
Could we exclude the remote openHAB binding from this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's figure that one out another time. 🙂
|
The bindings relying on a serial connection often also supports a serial connection over IP, so it is not easy to choose th eright option. |
Sorry if the following can be perceived as pedantic. My intention is only to try to get this right, now that we have this box opened. The original issue definition by @kaikreuzer (openhab/openhab-core#2058):
The documented definition (highlighting important words) by you (openhab/openhab-docs#1872):
And what you just wrote:
There are slight contradictions here, even between your own definitions. If it doesn't require cloud, but accesses cloud during normal operation, then according to your first definition it's inconclusive - it doesn't require cloud, but it also doesn't interact locally only. According to your new definition it would be For me as a user, the questions I would expect immediate answers for are:
We cannot clearly answer that with the current options. I would propose the following (explanations, not descriptions to be used):
|
Btw, sorry to hijack this PR @wborn, my last comment is clearly out of scope here and could be created as an issue. We can merge this PR now IMHO, but would you prefer to continue discussion here, or in a new issue in openhab-core? |
Perhaps it's best to create a new issue for resolving the ambiguities so all the tagged reviewers can optionally join it. |
Signed-off-by: Wouter Born <github@maindrain.net>
* Add more connection details to add-ons Signed-off-by: Wouter Born <github@maindrain.net>
Adds more connections details for add-ons I maintain, use or know a bit.
Related to #14885