Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boschindego] Add device properties #14829

Merged
merged 3 commits into from
Apr 22, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Apr 16, 2023

Adds some useful properties like Bosch bare tool number, model name and firmware version.

Use the model name as thing label from discovery.

Resolves #14828

Resolves openhab#14828

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Apr 16, 2023
@jlaur jlaur requested a review from jofleck as a code owner April 16, 2023 19:59
jlaur added 2 commits April 17, 2023 20:46
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from a team April 21, 2023 21:52
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 275329d into openhab:main Apr 22, 2023
@lolodomo lolodomo added this to the 4.0 milestone Apr 22, 2023
@jlaur jlaur deleted the 14828-boschindego-properties branch April 29, 2023 09:38
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
* Add device properties
* Add vendor and model properties
* Use model as label in discovery

Resolves openhab#14828

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[boschindego] Obtain device information and set as properties
2 participants