Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boschindego] Fix compliance with RFC 9110 section 10.1.5 #14891

Merged
merged 1 commit into from
May 1, 2023
Merged

[boschindego] Fix compliance with RFC 9110 section 10.1.5 #14891

merged 1 commit into from
May 1, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Apr 27, 2023

Minor follow-up to #14745 for compliance with RFC 9110 section 10.1.5.

@jlaur
Fix compliance with RFC 9110 section 10.1.5
9499fe0 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Apr 27, 2023
@jlaur jlaur requested a review from jofleck as a code owner April 27, 2023 20:11
@jlaur jlaur requested a review from a team April 28, 2023 20:41
lolodomo
lolodomo approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit fafcc68 into openhab:main May 1, 2023
@lolodomo lolodomo added this to the 4.0 milestone May 1, 2023
@jlaur jlaur deleted the 14536-boschindego-user-agent branch May 1, 2023 17:59
@jlaur
Copy link
Contributor Author

jlaur commented May 1, 2023

@lolodomo - would it be fine with you to cherry-pick this into the 3.4.x branch as well?

@lolodomo
Copy link
Contributor

lolodomo commented May 1, 2023

@lolodomo - would it be fine with you to cherry-pick this into the 3.4.x branch as well?

But #14745 was not ?

@jlaur
Copy link
Contributor Author

jlaur commented May 1, 2023

@lolodomo - would it be fine with you to cherry-pick this into the 3.4.x branch as well?

But #14745 was not ?

But #14812 was. 😉

@lolodomo
Copy link
Contributor

lolodomo commented May 1, 2023

Ok, so let's go.

jlaur added a commit that referenced this pull request May 1, 2023
@jlaur
Fix compliance with RFC 9110 section 10.1.5 (#14891)
91450d0 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label May 1, 2023
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@jlaur @tburri-alstom
Fix compliance with RFC 9110 section 10.1.5 (openhab#14891)
13d982d 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@jlaur @matchews
Fix compliance with RFC 9110 section 10.1.5 (openhab#14891)
066c9d8 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
Fix compliance with RFC 9110 section 10.1.5 (openhab#14891)
2d7993f 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@jofleck jofleck Awaiting requested review from jofleck jofleck is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jlaur @lolodomo