Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] Fix NUPnP discovery #14918

Merged
merged 1 commit into from
May 6, 2023
Merged

[hue] Fix NUPnP discovery #14918

merged 1 commit into from
May 6, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 1, 2023

First commit from #14871 cherry-picked.

@jlaur
Fix NUPnP discovery
13bdf1a 
Fixes openhab#14852

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch labels May 1, 2023
@jlaur jlaur requested a review from a team May 1, 2023 19:06
@jlaur jlaur requested a review from cweitkamp as a code owner May 1, 2023 19:06
@jlaur
Copy link
Contributor Author

jlaur commented May 3, 2023

@lolodomo - this is a 3.4 backport of #14871 based on same commit, but omitting the second commit from that PR which updated the connection. Perhaps you could consider this as well?

@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 5, 2023
@jlaur
Copy link
Contributor Author

jlaur commented May 5, 2023

I don't know why the integration test fails.

@lolodomo
Copy link
Contributor

lolodomo commented May 6, 2023

If the integration tests are failing, it looks not reasonable to merge ? It will then break the preparation of next 3.4 release ?

@jlaur
Copy link
Contributor Author

jlaur commented May 6, 2023

If the integration tests are failing, it looks not reasonable to merge ?

The question (to which I don't have an answer yet) is why they are failing. I suspect it's unrelated to these changes, since they didn't fail the integration tests in the main branch.

@jlaur jlaur mentioned this pull request May 6, 2023
Closed
@jlaur
Copy link
Contributor Author

jlaur commented May 6, 2023

@lolodomo - unrelated, see #14948 and https://ci.openhab.org/job/PR-openHAB-Addons/15513/

lolodomo
lolodomo approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented May 6, 2023

Ok, so I merge, I just hope that @kaikreuzer will not kill us when he will start the build of branch 3.4.x ;)

@lolodomo lolodomo merged commit 604b354 into openhab:3.4.x May 6, 2023
@jlaur
Copy link
Contributor Author

jlaur commented May 6, 2023 •
edited
Loading

@lolodomo - in case of any killing, we should have a chance to escape since something else must have broken the integration tests. 😉 And still the builds are successful: https://ci.openhab.org/view/Sandbox/job/sandbox-openhab3-patch-release/

@jlaur jlaur deleted the 14852-hue-fix-nupnp-discovery-3.4.x branch May 6, 2023 10:43
@jlaur jlaur mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlaur @lolodomo