Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rrd4j] Add console commands to check and clean RRD files #14960

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented May 9, 2023

Console commands added to detect and remove RRD files associated with items that no longer exist.

Signed-off-by: Laurent Garnier lg.hc@free.fr

Console commands added to detect and remove RRD files associated with items
that no longer exist.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label May 9, 2023
@lolodomo lolodomo requested a review from a team as a code owner May 9, 2023 19:04
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A helpful addition! In the past I did this manually when upgrading old OH instances.
Code LGTM.

I gave it a try on my RPI test system, it worked as intended.

Maybe you could add some user documentation? I was - until now - not aware that addons can easily add console commands.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commands!

@wborn wborn merged commit 6686e18 into openhab:main Jun 16, 2023
@wborn wborn added this to the 4.0 milestone Jun 16, 2023
@lolodomo lolodomo deleted the rrd4j_console_cmd branch June 16, 2023 07:21
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
)

Console commands added to detect and remove RRD files associated with items that no longer exist.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
@DrScr3w
Copy link

DrScr3w commented Jul 31, 2023

Hello and thank you, but how can I use the Command, is there a documentation?

@wborn
Copy link
Member

wborn commented Jul 31, 2023

Yes you can use it by logging into the Console.

The command has its own help:

openhab> openhab:rrd4j --help
Usage: openhab:rrd4j list - list Round Robin Database files
Usage: openhab:rrd4j check - check for RRD files without existing item
Usage: openhab:rrd4j clean [<itemName>] - delete RRD files without existing item

@DrScr3w
Copy link

DrScr3w commented Aug 7, 2023

Thank you this is a very helpful command

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
)

Console commands added to detect and remove RRD files associated with items that no longer exist.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
)

Console commands added to detect and remove RRD files associated with items that no longer exist.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants