[dynamodb] Changes required after API changes in core framework #14966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you inject the |
Good idea. |
Changes in openhab/openhab-core#3481 broke this service due to an breaking API change in NumberItem class (constructor). Related to openhab/openhab-core#3600 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
changed the title
|
Ok, it is now fully fixed. |
lolodomo
force-pushed
the
dynamodb_fix_tests
branch
from
7329ae7
to
a860523
Compare
|
@openhab/add-ons-maintainers : please review and merge ASAP so that we can get new snapshots again. |
lolodomo
added
bug
jlaur
added
the
regression
|
Thank you @jlaur |
|
@lolodomo - FYI, build failed because of another test: https://github.com/openhab/openhab-addons/actions/runs/4939114188/jobs/8829556438 |
I certainly forgot to grep in integration tests. |
|
openhab/openhab-core#3600 (comment) |
tb4jc
pushed a commit
to tb4jc/openhab-addons
that referenced
this pull request
Jun 19, 2023
…hab#14966) Changes in openhab/openhab-core#3481 broke this service due to an breaking API change in NumberItem class (constructor). Related to openhab/openhab-core#3600 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
…hab#14966) Changes in openhab/openhab-core#3481 broke this service due to an breaking API change in NumberItem class (constructor). Related to openhab/openhab-core#3600 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…hab#14966) Changes in openhab/openhab-core#3481 broke this service due to an breaking API change in NumberItem class (constructor). Related to openhab/openhab-core#3600 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in openhab/openhab-core#3481 broke this service due to a breaking API change in NumberItem class (constructor).
Related to openhab/openhab-core#3600
Signed-off-by: Laurent Garnier lg.hc@free.fr