[ipcamera] Fix discovery crashes when networks have access rights issues in docker #15059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
jlaur
requested changes
Jun 20, 2023
...nding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/onvif/OnvifDiscovery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
All requested changes have been made. |
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jul 8, 2023
…ues in docker (openhab#15059) * Fix discovery crashes if network use is blocked by docker. * Change log levels to be more useful. * add better reolink discovery check Signed-off-by: Matthew Skinner <matt@pcmus.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
…ues in docker (openhab#15059) * Fix discovery crashes if network use is blocked by docker. * Change log levels to be more useful. * add better reolink discovery check Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…ues in docker (openhab#15059) * Fix discovery crashes if network use is blocked by docker. * Change log levels to be more useful. * add better reolink discovery check Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported here that most likely is an access issue caused by the use of docker. Closes #14500
It restricts the binding to only search the network that openHAB has setup as the primary address so if one of your networks causes issues the binding will no longer try to search using all internal networks, but only the selected one.
The PR also improves the discovery of cameras that do not reply with an ONVIF xaddress and will try to discover the brand from the cameras login page.
This pull request will automatically be built and available under the following links if anyone wants to test:
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.ipcamera/4.0.0-SNAPSHOT/org.openhab.binding.ipcamera-4.0.0-SNAPSHOT.jar
Signed-off-by: Matthew Skinner matt@pcmus.com