-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enphase] Add Entrez/JWT support for newer software versions of Envoy #15077
Conversation
Hallo Hilbrand, |
@joseil You can find the jar file in this community message: https://community.openhab.org/t/new-binding-enphase-envoy-solar-system-gateway/44449/94 |
Hallo Hilbrand,
bedankt voor de info, het is gelukt
groeten Jos
Op di 13 jun 2023 om 17:15 schreef Hilbrand Bouwkamp <
***@***.***>:
… @joseil <https://github.com/joseil> You can find the jar file in this
community message:
https://community.openhab.org/t/new-binding-enphase-envoy-solar-system-gateway/44449/94
—
Reply to this email directly, view it on GitHub
<#15077 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJRWDZY6F27Q4T2RH63XSTXLB7XJANCNFSM6AAAAAAZBXGGZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
8bad72d
to
827b0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care! I have added some minor comments.
I believe update instructions are needed because of the channel group changes.
Also, it seems connection is now hybrid or cloud rather than local?
...nding.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyConnector.java
Outdated
Show resolved
Hide resolved
...nding.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyConnector.java
Outdated
Show resolved
Hide resolved
...nphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyConnectorWrapper.java
Outdated
Show resolved
Hide resolved
827b0e1
to
352488a
Compare
I've changed connection to hybrid, although it's only a small part. Because only for certain versions of the Enphase software it's needed to get the authorization, which only needs to be done after certain period of time. All reading of the data is still local. It doesn't seem to need a migration update. Because the group type id has changed and that information is not stored in the json database. Therefor after installing the new version of the binding the channels created in the ui keep working. |
👍 Still, items need to be relinked, right? So probably should be mentioned after: |
Does this mean that without the cloud, it will not be possible to get the authorization and read data locally? Or is this cloud authorization not needed for using the local API? |
Items should be automatically relinked, because the channel names itself didn't change. Therefor I would not expect an issue. I did test this, and it did just relink the items. Although someone on the forum did mention problems with the items linking when updating the binding, but I don't understand what is the cause or if/how that is related to the rename of the group type id.
The Envoys with the newer software version require authorization. It is required to get the jwt from the portal, either by login to the portal and get the jwt and configure the jwt or config login and than the jwt will be obtained from the portal by the binding. After setting the jwt it can use the local API and no cloud connection is needed. So yes the jwt from the portal is needed. But once one has the jwt the binding doesn't need cloud connection. |
Sorry, I mixed changed id with changed group name. Since the id is changed, I would have suspected issues for managed things without update instructions, but since you tested this, apparently there is no issue. Channel relinking was a brainfart - that would only be needed if channel group name changed.
Hmm, I never heard of such a solution before. If the cloud services will be shut down (for any reason), the integration will stop working, even though it actually runs locally. By the definition it's actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…of Envoy Co-authored-by: Joe Inkenbrandt <joe@inkenbrandt.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
…Enphase portal. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
ddae481
to
11c0ef7
Compare
I'm sorry, this PR somehow got off my radar. I guess I was waiting for a reply here - but assuming silent agreement now. 😉 |
…openhab#15077) Co-authored-by: Joe Inkenbrandt <joe@inkenbrandt.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
…openhab#15077) Co-authored-by: Joe Inkenbrandt <joe@inkenbrandt.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
…openhab#15077) Co-authored-by: Joe Inkenbrandt <joe@inkenbrandt.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
…openhab#15077) Co-authored-by: Joe Inkenbrandt <joe@inkenbrandt.com> Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Adds support for newer Envoy software version that currently is not supported by the binding.
See also https://community.openhab.org/t/new-binding-enphase-envoy-solar-system-gateway/44449/113