[Helios] Fix error handling + migrate to the injected JAX-RS ClientBuilder #15096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
jlaur
requested changes
Jun 15, 2023
...b.binding.helios/src/main/java/org/openhab/binding/helios/internal/HeliosHandlerFactory.java
Outdated
Show resolved
Hide resolved
...nding.helios/src/main/java/org/openhab/binding/helios/internal/handler/HeliosHandler221.java
Outdated
Show resolved
Hide resolved
kgoderis
force-pushed
the
helios-fix-connect
branch
3 times, most recently
from
1aa5dcb to
8344c45
Compare
jlaur
reviewed
Jun 15, 2023
...nding.helios/src/main/java/org/openhab/binding/helios/internal/handler/HeliosHandler221.java
Outdated
Show resolved
Hide resolved
kgoderis
force-pushed
the
helios-fix-connect
branch
2 times, most recently
from
9132417 to
16ce1a0
Compare
jlaur
requested changes
Jun 16, 2023
...nding.helios/src/main/java/org/openhab/binding/helios/internal/handler/HeliosHandler221.java
Outdated
Show resolved
Hide resolved
...nding.helios/src/main/java/org/openhab/binding/helios/internal/handler/HeliosHandler221.java
Outdated
Show resolved
Hide resolved
...nding.helios/src/main/java/org/openhab/binding/helios/internal/handler/HeliosHandler221.java
Outdated
Show resolved
Hide resolved
Signed-Off-By: Karel Goderis <karel.goderis@me.com>
kgoderis
force-pushed
the
helios-fix-connect
branch
from
16ce1a0 to
62127a3
Compare
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
…enhab#15096) Signed-off-by: Karel Goderis <karel.goderis@me.com> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…enhab#15096) Signed-off-by: Karel Goderis <karel.goderis@me.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openhab/openhab-distro#1546
Signed-Off-By: Karel Goderis karel.goderis@me.com