[sungrow] Initial contribution #15130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soenkekueper
added
new binding
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
jlaur
reviewed
Jul 16, 2023
jlaur
reviewed
Jul 16, 2023
wborn
reviewed
Jul 24, 2023
soenkekueper
force-pushed
the
sungrow
branch
3 times, most recently
from
efb341b to
cbee75a
Compare
soenkekueper
removed
the
work in progress
soenkekueper
changed the title
wborn
reviewed
Dec 23, 2023
lsiepel
requested changes
Dec 29, 2023
...ungrow/src/main/java/org/openhab/binding/modbus/sungrow/internal/SungrowInverterHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.modbus.sungrow/src/main/resources/OH-INF/i18n/sungrow_de.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.modbus.sungrow/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.modbus.sungrow/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
…king. Added categories and tags for channels. Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
… (instead of floats issues). Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
|
Thanks for your review @lsiepel. |
lsiepel
requested changes
Jan 3, 2024
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Yes, battery information is working and documentation is updated. |
|
@lsiepel Is everything ok now, or do you have any further comments / questions? |
Some comments are marked as resolved, but i don't see any change or comment. Did you push all changes? Can you check all of them and add a comment like 'fxied' or the reason why it is not canged? |
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
|
Sorry i don't know what happend - maybe some rebase/merging error on my side. sorry for that. |
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
approved these changes
Feb 19, 2024
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* 0000: Implementation --------- Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Leo Siepel <leosiepel@gmail.com> Co-authored-by: Wouter Born <github@maindrain.net> Co-authored-by: Eric Bodden <eric.bodden@upb.de> Co-authored-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* 0000: Implementation --------- Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Leo Siepel <leosiepel@gmail.com> Co-authored-by: Wouter Born <github@maindrain.net> Co-authored-by: Eric Bodden <eric.bodden@upb.de> Co-authored-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Content
This PR implements a new modbus binding for openHAB, that integrates Sungrow inverters.
With this binding its very easy to monitor the current values for PV production within the smart home system - without the need to worry about modbus registers, types and transformations. It's implemented along the Sungrow specification "Communication Protocol of Residential Hybrid Inverter V1.0.23",
which can be found here: bohdan-s/SunGather#36.
The binding adds a new thing type "sungrow inverter" that uses the default modbus bridges and needs no further configuration.
ToDos
- Check provided values for battery information- complete documentationThis binding was already mentioned within thread https://community.openhab.org/t/sungrow-inverter-binding-or-modbus-config/139360/17.