-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[intesis] Add configurable polling interval #15138
Conversation
Signed-off-by: hmerk <github@hmerk.de>
Signed-off-by: hmerk <github@hmerk.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have added some comments, but also have a concern that it doesn't work at all because of a typo: thing-tyles.xml
defines parameters as "pollingInterval", but it's deserialized as "pollingIntervall".
...tesis/src/main/java/org/openhab/binding/intesis/internal/config/IntesisBoxConfiguration.java
Outdated
Show resolved
Hide resolved
...esis/src/main/java/org/openhab/binding/intesis/internal/config/IntesisHomeConfiguration.java
Outdated
Show resolved
Hide resolved
...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java
Outdated
Show resolved
Hide resolved
...g.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisHomeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/config/IntesisBoxConfiguration.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/config/IntesisHomeConfiguration.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/handler/IntesisBoxHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/handler/IntesisHomeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
@jlaur Anything else ? All your suggestions have been committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, I had missed your commits. Looks good now. 👍 Can you confirm it has been tested now, because I think it could not have worked with the initial commit? |
Yes, tested and working. |
Signed-off-by: hmerk <github@hmerk.de>
Signed-off-by: hmerk <github@hmerk.de> Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: hmerk <github@hmerk.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Signed-off-by: Hans-Jörg Merk github@hmerk.de