Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intesis] Add configurable polling interval #15138

Merged
merged 11 commits into from
Jul 2, 2023
Merged

Conversation

hmerk
Copy link
Contributor

@hmerk hmerk commented Jun 26, 2023

Signed-off-by: Hans-Jörg Merk github@hmerk.de

Signed-off-by: hmerk <github@hmerk.de>
@hmerk hmerk added the enhancement An enhancement or new feature for an existing add-on label Jun 26, 2023
Signed-off-by: hmerk <github@hmerk.de>
@hmerk hmerk requested a review from a team June 26, 2023 11:24
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have added some comments, but also have a concern that it doesn't work at all because of a typo: thing-tyles.xml defines parameters as "pollingInterval", but it's deserialized as "pollingIntervall".

@wborn wborn changed the title [intesis] Add configurable polling intervall [intesis] Add configurable polling interval Jun 26, 2023
hmerk and others added 9 commits June 26, 2023 17:10
Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/config/IntesisBoxConfiguration.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/config/IntesisHomeConfiguration.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/handler/IntesisBoxHandler.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…binding/intesis/internal/handler/IntesisHomeHandler.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
…thing/thing-types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
@hmerk hmerk requested a review from jlaur June 26, 2023 20:11
@hmerk
Copy link
Contributor Author

hmerk commented Jul 2, 2023

@jlaur Anything else ? All your suggestions have been committed.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur
Copy link
Contributor

jlaur commented Jul 2, 2023

Anything else ? All your suggestions have been committed.

Sorry, I had missed your commits. Looks good now. 👍 Can you confirm it has been tested now, because I think it could not have worked with the initial commit?

@hmerk
Copy link
Contributor Author

hmerk commented Jul 2, 2023

Yes, tested and working.

@jlaur jlaur merged commit ea7eb9f into openhab:main Jul 2, 2023
@jlaur jlaur added this to the 4.0 milestone Jul 2, 2023
@hmerk hmerk deleted the instesis-polling branch July 2, 2023 19:45
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Jul 8, 2023
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
Signed-off-by: hmerk <github@hmerk.de>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: hmerk <github@hmerk.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants