Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ihc] Fix special character issue on item descriptions #15183

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

paulianttila
Copy link
Contributor

Fixed special character issue on item descriptions. Also changed thing status to UNKNOWN when initializing.

Signed-off-by: Pauli Anttila pauli.anttila@gmail.com

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only one comment for correct status handling.

@jlaur jlaur changed the title [ihc] fixed special character issue on item descriptions [ihc] Fix special character issue on item descriptions Jul 5, 2023
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jul 5, 2023
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 1ce6e87 into openhab:main Jul 7, 2023
@jlaur jlaur added this to the 4.0 milestone Jul 7, 2023
@paulianttila paulianttila deleted the ihc-fixes branch July 7, 2023 07:35
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Jul 8, 2023
* [ihc] fix special character issue on item descriptions
* [ihc] Changed thing status to UNKNOWN when initializing

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
* [ihc] fix special character issue on item descriptions
* [ihc] Changed thing status to UNKNOWN when initializing

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [ihc] fix special character issue on item descriptions
* [ihc] Changed thing status to UNKNOWN when initializing

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants