Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Openuv] Provide UV Index iconset #15191

Merged
merged 3 commits into from
Jul 13, 2023
Merged

[Openuv] Provide UV Index iconset #15191

merged 3 commits into from
Jul 13, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Jul 6, 2023

Included some small Java 17 code improvement + addition of an icon server providing dedicated dynamic icons.

clinique added 2 commits July 6, 2023 15:41
@clinique
Initiating addition of an IconProvider
20bbc20 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding an icon server to OpenUV binding
0986b84 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique added the enhancement An enhancement or new feature for an existing add-on label Jul 6, 2023
@clinique clinique self-assigned this Jul 6, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Jul 12, 2023 •
edited
Loading

You are THE fan of this new feature ;)
Will try to find the time to review it.

@clinique
Copy link
Contributor Author

Yes, I think it greatly improves user experience when out of the box you've got some adapted icons and will not have to go chase them on Internet.

@lolodomo
Copy link
Contributor

@clinique : there is no copyright on the icons you are providing ?

@clinique
Copy link
Contributor Author

@clinique : there is no copyright on the icons you are providing ?

Generic (ozone, UV alert) come from SVG Repo (open license) and have been adapted by myself. The UV Index icons (1 to 11) are the standard found everywhere used to represent level and color.

@lolodomo
Copy link
Contributor

I think it greatly improves user experience when out of the box you've got some adapted icons and will not have to go chase them on Internet.

I fully agree.

@clinique
Copy link
Contributor Author

From what I see here, these logos can be used free of charge.

@clinique
Code review corrections
2f034fc 
Signed-off-by: clinique <gael@lhopital.org>
lolodomo
lolodomo approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 9b06e23 into openhab:main Jul 13, 2023
@lolodomo lolodomo added this to the 4.0 milestone Jul 13, 2023
@jlaur jlaur changed the title [Openuv] Providing an iconserver [Openuv] Provide an icon server Jul 13, 2023
@jlaur
Copy link
Contributor

jlaur commented Jul 13, 2023

@clinique - can we rephrase PR title to something user-oriented?

@clinique clinique deleted the openuv_iconserver branch July 13, 2023 12:32
@clinique clinique changed the title [Openuv] Provide an icon server [Openuv] Provide UV Index iconset Jul 13, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@clinique @austvik
[Openuv] Providing an iconserver (openhab#15191)
2ce9ede 
* Adding an icon server to OpenUV binding

---------

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees

@clinique clinique

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clinique @lolodomo @jlaur