[googletts] Replace custom TTS cache with common TTS cache #15208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't update the internationalization files for langage other than default. I believe it should be done inside the dedicated tool ? If not, please tell me. |
7 tasks
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
dalgwen
force-pushed
the
googletts_use_common_cache
branch
from
3c8cf1d to
877b272
Compare
lolodomo
requested changes
Jul 8, 2023
...hab.voice.googletts/src/main/java/org/openhab/voice/googletts/internal/GoogleTTSService.java
Outdated
Show resolved
Hide resolved
|
This TTS service is using a |
lolodomo
added
the
enhancement
Apply code review Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…5208) * [googletts] Replace custom TTS cache with common TTS cache -------- Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the common TTS cache instead of a custom one.
No new features
Relates to #15110
Advantages