Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plex] Use https for local connections #15306

Merged
merged 2 commits into from
Jul 26, 2023
Merged

[plex] Use https for local connections #15306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6fe08b
use https for local connections
mlobstein Jul 26, 2023
b342358
review changes
mlobstein Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 56 additions & 20 deletions ...inding.plex/src/main/java/org/openhab/binding/plex/internal/handler/PlexApiConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@
import java.net.URISyntaxException;
import java.util.Base64;
import java.util.Properties;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

import org.eclipse.jdt.annotation.NonNullByDefault;
import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.jetty.client.HttpClient;
import org.eclipse.jetty.client.api.ContentResponse;
import org.eclipse.jetty.client.api.Request;
import org.eclipse.jetty.http.HttpHeader;
import org.eclipse.jetty.websocket.api.Session;
import org.eclipse.jetty.websocket.api.annotations.OnWebSocketClose;
Expand Down Expand Up @@ -129,11 +133,12 @@ private void setupXstream() {
*/
public @Nullable MediaContainer getSessionData() {
try {
String url = "http://" + host + ":" + String.valueOf(port) + "/status/sessions" + "?X-Plex-Token=" + token;
String url = "https://" + host + ":" + String.valueOf(port) + "/status/sessions" + "?X-Plex-Token=" + token;
logger.debug("Getting session data '{}'", url);
MediaContainer mediaContainer = doHttpRequest("GET", url, getClientHeaders(), MediaContainer.class);
MediaContainer mediaContainer = getFromXml(doHttpRequest("GET", url, getClientHeaders(), false),
MediaContainer.class);
return mediaContainer;
} catch (IOException e) {
} catch (IOException | InterruptedException | TimeoutException | ExecutionException e) {
logger.debug("An exception occurred while polling the PLEX Server: '{}'", e.getMessage());
return null;
}
Expand All @@ -151,7 +156,7 @@ public String getURL(String url) {
}

/**
* This method will get an X-Token from the PLEX server if one is not provided in the bridge config
* This method will get an X-Token from the PLEX.tv server if one is not provided in the bridge config
* and use this in the communication with the plex server
*/
public void getToken() {
Expand All @@ -161,8 +166,8 @@ public void getToken() {
headers.put("Authorization", "Basic " + authString);

try {
user = doHttpRequest("POST", SIGNIN_URL, headers, User.class);
} catch (IOException e) {
user = getFromXml(doHttpRequest("POST", SIGNIN_URL, headers, true), User.class);
} catch (IOException | InterruptedException | TimeoutException | ExecutionException e) {
logger.debug("An exception occurred while fetching PLEX user token :'{}'", e.getMessage(), e);
throw new ConfigurationException("Error occurred while fetching PLEX user token, please check config");
}
Expand All @@ -176,11 +181,12 @@ public void getToken() {
}

/**
* This method will get the Api information from the PLEX servers.
* This method will get the Api information from the PLEX.tv servers.
*/
public boolean getApi() {
try {
MediaContainer api = doHttpRequest("GET", API_URL, getClientHeaders(), MediaContainer.class);
MediaContainer api = getFromXml(doHttpRequest("GET", API_URL, getClientHeaders(), true),
MediaContainer.class);
logger.debug("MediaContainer {}", api.getSize());
if (api.getDevice() != null) {
for (Device tmpDevice : api.getDevice()) {
Expand All @@ -198,28 +204,58 @@ public boolean getApi() {
}
}
return false;
} catch (IOException e) {
} catch (IOException | InterruptedException | TimeoutException | ExecutionException e) {
logger.debug("An exception occurred while fetching API :'{}'", e.getMessage(), e);
}
return false;
}

/**
* Make an HTTP request and return the class object that was used when calling.
* Make an HTTP request and return the response as a string.
*
* @param <T> Class being used(dto)
* @param method GET/POST
* @param url What URL to call
* @param headers Additional headers that will be used
* @param type class type for the XML parsing
* @return Returns a class object from the data returned by the call
* @param verify Flag to indicate if ssl certificate checking should be done
* @return Returns a string of the http response
* @throws IOException
* @throws ExecutionException
* @throws TimeoutException
* @throws InterruptedException
*/
private <T> T doHttpRequest(String method, String url, Properties headers, Class<T> type) throws IOException {
String response = HttpUtil.executeUrl(method, url, headers, null, null, REQUEST_TIMEOUT_MS);
private String doHttpRequest(String method, String url, Properties headers, boolean verify)
throws IOException, InterruptedException, TimeoutException, ExecutionException {
final String response;
if (verify) {
// Requests sent to the PLEX.tv servers should use certificate checking
response = HttpUtil.executeUrl(method, url, headers, null, null, REQUEST_TIMEOUT_MS);
jlaur marked this conversation as resolved.
Show resolved Hide resolved
} else {
// Requests sent to the local server need to bypass certificate checking via the custom httpClient
final Request request = httpClient.newRequest(url).method(HttpUtil.createHttpMethod(method));
for (String httpHeaderKey : headers.stringPropertyNames()) {
if (httpHeaderKey.equalsIgnoreCase(HttpHeader.USER_AGENT.toString())) {
request.agent(headers.getProperty(httpHeaderKey));
} else {
request.header(httpHeaderKey, headers.getProperty(httpHeaderKey));
}
}
final ContentResponse res = request.send();
response = res.getContentAsString();
Comment on lines +233 to +243
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morph166955 I was working on this change to catch the failure and re-try with http

        try {
                // Requests sent to the local server need to bypass certificate checking via the custom httpClient
                final Request request = httpClient.newRequest(url).method(HttpUtil.createHttpMethod(method));
                for (String httpHeaderKey : headers.stringPropertyNames()) {
                    if (httpHeaderKey.equalsIgnoreCase(HttpHeader.USER_AGENT.toString())) {
                        request.agent(headers.getProperty(httpHeaderKey));
                    } else {
                        request.header(httpHeaderKey, headers.getProperty(httpHeaderKey));
                    }
                }
                final ContentResponse res = request.send();
                response = res.getContentAsString();
            } catch (Exception e) {
                // if https conection to the local server fails, re-try with http
                response = HttpUtil.executeUrl(method, url.replace("https:", "http:"), headers, null, null, REQUEST_TIMEOUT_MS);
            }

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think this is a bad idea. We shouldn't fall back to insecure urls if connection fails. Instead we have to find out why it fails and fix the https connection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll let you sort it out. It was just rather alarming that a problem report came in right after the first nightly build of this PR.

Copy link
Contributor

@jlaur jlaur Jul 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps an advanced configuration option could allow users to explicitly use http rather than https? I agree it shouldn't silently fallback to http for security reasons. See also useTLS here (which is defaulted to true): https://www.openhab.org/addons/bindings/lgwebos/#thing-configuration

}
logger.debug("HTTP response: {}", response);
return response;
}

/**
* Return the class object that was represented by the xml input string.
*
* @param response The xml response to parse
* @param type Class type for the XML parsing
* @return Returns a class object from the input sring
*/
private <T> T getFromXml(String response, Class<T> type) {
@SuppressWarnings("unchecked")
T obj = (T) xStream.fromXML(response);
logger.debug("HTTP response {}", response);
return obj;
}

Expand All @@ -230,7 +266,7 @@ private <T> T doHttpRequest(String method, String url, Properties headers, Class
*/
private Properties getClientHeaders() {
Properties headers = new Properties();
headers.put(HttpHeader.USER_AGENT, "openHAB / PLEX binding "); // + VERSION);
headers.put(HttpHeader.USER_AGENT, "openHAB/" + org.openhab.core.OpenHAB.getVersion() + " PLEX binding");
headers.put("X-Plex-Client-Identifier", CLIENT_ID);
headers.put("X-Plex-Product", "openHAB");
headers.put("X-Plex-Version", "");
Expand Down Expand Up @@ -377,11 +413,11 @@ public void controlPlayer(Command command, String playerID) {

if (commandPath != null) {
try {
String url = "http://" + host + ":" + String.valueOf(port) + commandPath;
String url = "https://" + host + ":" + String.valueOf(port) + commandPath;
Properties headers = getClientHeaders();
headers.put("X-Plex-Target-Client-Identifier", playerID);
HttpUtil.executeUrl("GET", url, headers, null, null, REQUEST_TIMEOUT_MS);
} catch (IOException e) {
doHttpRequest("GET", url, headers, false);
} catch (IOException | InterruptedException | TimeoutException | ExecutionException e) {
logger.debug("An exception occurred trying to send command '{}' to the player: {}", commandPath,
e.getMessage());
}
Expand Down
1 change: 1 addition & 0 deletions ...nding.plex/src/main/java/org/openhab/binding/plex/internal/handler/PlexServerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ public void initialize() {
try {
SslContextFactory.Server sslContextFactory = new SslContextFactory.Server();
sslContextFactory.setEndpointIdentificationAlgorithm(null);
sslContextFactory.setTrustAll(true);
HttpClient localHttpClient = httpClient = httpClientFactory.createHttpClient(httpClientName,
sslContextFactory);
localHttpClient.start();
Expand Down