-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsscripting] Upgrade openhab-js to fix cached library injection #15336
Conversation
It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection. openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#451.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you fix the DCO? Would you agree this should be backported to 4.0.x as a regression?
Is it enough to comment DCO? Signed-off-by: Florian Hotze florianh_dev@icloud.com
Yes, just give me one or two day(s) to test the SNAPSHOT before backporting this. |
@jlaur I've tested the fix, works great! This is ready to be backported now. |
…5336) It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection. openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#451. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/20-seconds-delay-until-js-script-gets-executed/148181/6 |
…enhab#15336) It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection. openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#451. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection.
openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/v4.5.1/CHANGELOG.md#451.