-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dwdunwetter] Improve server problem handling #15405
Conversation
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, it looks like a simple approach to pre check some data. Currently you are testing only for <?xml
which is quite generic. What do you think about extending this check to some words which appear in every download, e.g. FeatureCollection
?
It is not meant to check data correctness. It is a check only to determine of the service works under normal conditions. If the output is xml, it can be assumed to be correct according to the API documentation. If it is not XML, the service is down, degraded, in maintenance or similar. |
Sure, that's something i would not expect in smallest detail. But as HTML (showing an Error) can be valid XML including the |
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. A quick functional test did also work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
* Fix openhab#14691 * Add country tag --------- Signed-off-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Fix openhab#14691 * Add country tag --------- Signed-off-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Fix openhab#14691 * Add country tag --------- Signed-off-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Fix openhab#14691 * Add country tag --------- Signed-off-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
* Fix openhab#14691 * Add country tag --------- Signed-off-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Used it for a couple of days and had no problem.
Test jar 4.1.0 here: https://1drv.ms/u/s!AnMcxmvEeupwjrMmX76PHq61-JUHFQ?e=K0E0TR