-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr064] Fix clearing of auth (results) #15415
Conversation
In case of multiple root things the auth store (results and digests) was cleared for all clients instead of only removing the failed auth result or old authentication. Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! One minor comment for consideration.
@@ -244,7 +244,7 @@ private State processMacSignalStrength(State state, Tr064ChannelConfig channelCo | |||
@SuppressWarnings("unused") | |||
private State processTamListURL(State state, Tr064ChannelConfig channelConfig) throws PostProcessingException { | |||
try { | |||
ContentResponse response = httpClient.newRequest(state.toString()).timeout(timeout, TimeUnit.MILLISECONDS) | |||
ContentResponse response = httpClient.newRequest(state.toString()).timeout(timeout, TimeUnit.SECONDS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the instance variable timeout
could also be renamed to timeoutSeconds
or similar to avoid such mistake from being repeated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is necessary. It was a refactoring error when the configurable timeouts were introduced in #14468 (the fixed value was in ms).
* [tr064] Fix clearing of auth (results) In case of multiple root things the auth store (results and digests) was cleared for all clients instead of only removing the failed auth result or old authentication. * fix TAM request Signed-off-by: Jan N. Klug <github@klug.nrw>
Can I still download the snapshot binding (org.openhab.binding.tr064-4.1.0-SNAPSHOT.jar) from somewhere? I don´t want to upgrade my complete openHAB to the not yet released 4.1.0 version. |
@Intenos - the fix was included in 4.0.2, see https://github.com/openhab/openhab-distro/releases/tag/4.0.2. |
Fantastic! It works. Thanks a lot! |
* [tr064] Fix clearing of auth (results) In case of multiple root things the auth store (results and digests) was cleared for all clients instead of only removing the failed auth result or old authentication. * fix TAM request Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
In case of multiple root things the auth store (results and digests) was cleared for all clients instead of only removing the failed auth result or old authentication.
Also fixes TAM list request.