Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[denonmarantz] Fix NullPointerException on connection problem #15422

Merged
merged 6 commits into from
Aug 18, 2023
Merged

[denonmarantz] Fix NullPointerException on connection problem #15422

merged 6 commits into from
Aug 18, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Aug 14, 2023 •
edited
Loading

@lsiepel
Checkstyle cleanup
c58e902 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from jwveldhuis as a code owner August 14, 2023 14:24
holgerfriedrich
holgerfriedrich approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lsiepel
Fix openhab#15444
98f037c 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel added work in progress A PR that is not yet ready to be merged bug An unexpected problem or unintended behavior of an add-on labels Aug 17, 2023
@lsiepel lsiepel changed the title [denonmarantz] Checkstyle cleanup [denonmarantz] Fix NPE on connection problem Aug 17, 2023
@lsiepel lsiepel removed the work in progress A PR that is not yet ready to be merged label Aug 17, 2023
@lsiepel
Fix review comment
29d8c21 
Signed-off-by: lsiepel <leosiepel@gmail.com>
holgerfriedrich
holgerfriedrich approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

jlaur
jlaur approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - LGTM!

I can also confirm that it works. I was able to reproduce the NPE from the 4.0.2 version, and with the fix the Thing will correctly transition between ONLINE and OFFLINE when turning the receiver on/off.

@jlaur jlaur merged commit 5c6fabb into openhab:main Aug 18, 2023
@jlaur jlaur added this to the 4.1 milestone Aug 18, 2023
jlaur pushed a commit that referenced this pull request Aug 18, 2023
@lsiepel @jlaur
[denonmarantz] Fix NPE on connection problem (#15422)
727e5b2 
* Checkstyle cleanup
* Fix #15444

Signed-off-by: lsiepel <leosiepel@gmail.com>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Aug 18, 2023
@jlaur jlaur changed the title [denonmarantz] Fix NPE on connection problem [denonmarantz] Fix NullPointerException on connection problem Aug 18, 2023
@lsiepel lsiepel deleted the denonmarantz-checkstyle branch August 18, 2023 14:47
mbronk pushed a commit to mbronk/openhab-addons that referenced this pull request Aug 21, 2023
@lsiepel @mbronk
[denonmarantz] Fix NPE on connection problem (openhab#15422)
214ac91 
* Checkstyle cleanup
* Fix openhab#15444

Signed-off-by: lsiepel <leosiepel@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
[denonmarantz] Fix NPE on connection problem (openhab#15422)
02fa548 
* Checkstyle cleanup
* Fix openhab#15444

Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[denonmarantz] Cannot invoke BufferReader syslog
3 participants
@lsiepel @holgerfriedrich @jlaur