Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meteofrance] Replacement of meteoalerte binding #15462

Merged
merged 26 commits into from
Sep 27, 2024
Merged

[meteofrance] Replacement of meteoalerte binding #15462

merged 26 commits into from
Sep 27, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Aug 19, 2023 •
edited
Loading

Resolves #15461 .

Data feed changed completely, this will have major impact on binding organization.

This binding also integrates another Meteo France service : rain previsions over the coming hour.

Being more generic, it has been renamed and meteoalerte binding should be removed.

@clinique clinique added bug An unexpected problem or unintended behavior of an add-on work in progress A PR that is not yet ready to be merged labels Aug 19, 2023
@clinique clinique self-assigned this Aug 19, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/meteo-alerte-binding-do-not-receive-data-since-may-2023/148545/5

@clinique clinique force-pushed the meteoalerte_new_feed branch from bb043b9 to cdea557 Compare March 29, 2024 15:46
@clinique clinique removed the work in progress A PR that is not yet ready to be merged label Apr 2, 2024
@clinique clinique requested a review from holgerfriedrich April 2, 2024 16:39
@clinique
Copy link
Contributor Author

clinique commented Apr 2, 2024

Ready to test : https://drive.google.com/file/d/10PtEt5kjDpJo84eNnsonbno83SEdWuOW/view?usp=drive_link

holgerfriedrich
holgerfriedrich reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clinique I am not sure if I am a good reviewer for this binding.... For now, I just checked a few code style topics, javadoc has only expected warnings, i18n property file is in sync. That is what I can do today.
Find my suggestions below.

...hab.binding.meteoalerte/src/main/java/org/openhab/binding/meteoalerte/internal/dto/Term.java Outdated Show resolved Hide resolved
...binding.meteoalerte/src/main/java/org/openhab/binding/meteoalerte/internal/dto/BlocType.java Outdated Show resolved Hide resolved
...lerte/src/main/java/org/openhab/binding/meteoalerte/internal/handler/MeteoAlerteHandler.java Outdated Show resolved Hide resolved
...teoalerte/src/main/java/org/openhab/binding/meteoalerte/internal/db/DepartmentDbService.java Outdated Show resolved Hide resolved
@clinique
Copy link
Contributor Author

clinique commented Apr 2, 2024

@lolodomo : if you can start to have a look at this. I think it's pretty ready codewise. Documentation still has to be updated.

@clinique clinique requested review from lolodomo and jlaur April 2, 2024 23:23
@clinique clinique changed the title [meteoalerte] Adapting binding to new data feed [meteoalerte] Resurrect the binding Apr 3, 2024
@clinique
Copy link
Contributor Author

@lolodomo : can I kindly request a review ?

holgerfriedrich
holgerfriedrich reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 minor comments regarding the README...

bundles/org.openhab.binding.meteoalerte/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteoalerte/README.md Outdated Show resolved Hide resolved
holgerfriedrich
holgerfriedrich reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this one seems missing.
Otherwise the parts I have looked at LGTM, leaving the code review to @lolodomo.

bundles/org.openhab.binding.meteoalerte/README.md Outdated Show resolved Hide resolved
@clinique
Copy link
Contributor Author

@lolodomo : as you're currently working only for me 😀 , maybe you can have a look at this one also ?

@lolodomo
Copy link
Contributor

@lolodomo : as you're currently working only for me 😀 , maybe you can have a look at this one also ?

I hope you appreciate :)
That is not fully true, I am also working for @mherwege , my top priority regarding reviews ;)

@clinique clinique force-pushed the meteoalerte_new_feed branch from a2fb986 to 5007393 Compare May 28, 2024 15:03
@clinique clinique force-pushed the meteoalerte_new_feed branch from 5007393 to 2cc4b74 Compare June 24, 2024 08:21
@clinique clinique requested a review from a team as a code owner June 25, 2024 10:12
@clinique clinique changed the title [meteoalerte] Resurrect the binding [meteofrance] New binding Jun 25, 2024
@clinique
Adapting binding to new data feed
e25343d 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Spotless apply was missing
db222ba 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adapting binding to new data feed
dc02f9a 
Small and slow progress

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@clinique
Department handler is now ok.
630db37 
Data is ok.
Still has to take care of auto refresh and we're ready to go.

Signed-off-by: clinique <gael@lhopital.org>
@clinique
Applied spotless
7bc9824 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Code review
d9ec9c0 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Enhancement - comments are not always provided
a2362b3 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Addition of next hour rain prevision
fb57f45 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Spotless and i18n
ac944ff 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Removed initial state of the intensity
b497267 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Renamed from Meteo Alerte to Meteo France
97d232a 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Switched to 4.3
217c264 
Renamed from Meteo Alerte to Meteo France

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Two small correction and rebased
68c6fec 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique force-pushed the meteoalerte_new_feed branch from dc17bf9 to 68c6fec Compare August 20, 2024 13:47
@clinique
Pleasing SAT
62edd3f 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique added the enhancement An enhancement or new feature for an existing add-on label Aug 21, 2024
lsiepel
lsiepel requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviving this binding. As @lolodomo has chosen to work for anotther contributer ;-) i took the change and reviewed this PR.
Covered all files and after this initial round i expect jus a smaller last round before a merge. Ping me when you are ready to proceed.

bom/openhab-addons/pom.xml Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/README.md Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/README.md Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/README.md Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/meteofrance/internal/handler/MeteoFranceChildHandler.java Outdated Show resolved Hide resolved
...ance/src/main/java/org/openhab/binding/meteofrance/internal/handler/RainForecastHandler.java Show resolved Hide resolved
...ance/src/main/java/org/openhab/binding/meteofrance/internal/handler/RainForecastHandler.java Outdated Show resolved Hide resolved
...ofrance/src/main/java/org/openhab/binding/meteofrance/internal/handler/VigilanceHandler.java Show resolved Hide resolved
...ofrance/src/main/java/org/openhab/binding/meteofrance/internal/handler/VigilanceHandler.java Outdated Show resolved Hide resolved
@clinique
Code review corrections
d7b8e31 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique requested a review from lsiepel September 25, 2024 08:09
lsiepel
lsiepel requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some previous comments are open and found some new ones. I expect this to be the last pass.

bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/rain-forecast.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.meteofrance/src/main/resources/OH-INF/thing/vigilance.xml Outdated Show resolved Hide resolved
...ance/src/main/java/org/openhab/binding/meteofrance/internal/handler/RainForecastHandler.java Outdated Show resolved Hide resolved
@clinique
Code review corrections n°3
d604daf 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@lsiepel lsiepel merged commit 953e082 into openhab:main Sep 27, 2024
2 of 5 checks passed
@lsiepel
Copy link
Contributor

lsiepel commented Sep 27, 2024 •
edited
Loading

Thank you for adapting this binding. There are some additional steps to do.

  1. Could you add an update notification that the binding has been renamed here: https://github.com/openhab/openhab-distro/blob/main/distributions/openhab/src/main/resources/bin/update.lst
  2. Remove existing and add new or move the existing binding logo at the openHAB website. See:
    https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

Edit: Note to self and whoever it concerns: for future binding replacements, it is better to seperate the removal and add the new binding in two seperate PR's so they show up indepent in the changelog and can be backported (removal)

@lsiepel lsiepel added (potentially) not backward compatible and removed bug An unexpected problem or unintended behavior of an add-on labels Sep 27, 2024
@lsiepel lsiepel changed the title [meteofrance] New binding [meteofrance] Replacing meteoalerte binding Sep 27, 2024
@lsiepel lsiepel changed the title [meteofrance] Replacing meteoalerte binding [meteofrance] Replacement of meteoalerte binding Sep 27, 2024
@clinique clinique deleted the meteoalerte_new_feed branch September 27, 2024 11:33
@clinique
Copy link
Contributor Author

Update notification added : openhab/openhab-distro#1687

@clinique
Copy link
Contributor Author

Icons updated here: openhab/openhab-docs#2375

@clinique
Copy link
Contributor Author

Thanks for you help in reviewing and finalizing this, @lsiepel

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@clinique @joni1993
[meteofrance] New binding (openhab#15462)
c217896 
* Adapting binding to new data feed

Signed-off-by: clinique <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@clinique @matchews
[meteofrance] New binding (openhab#15462)
3368f05 
* Adapting binding to new data feed

Signed-off-by: clinique <gael@lhopital.org>
@holgerfriedrich holgerfriedrich added this to the 4.3 milestone Nov 11, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@clinique
[meteofrance] New binding (openhab#15462)
b109ee3 
* Adapting binding to new data feed

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel requested changes

@holgerfriedrich holgerfriedrich holgerfriedrich left review comments

@lolodomo lolodomo Awaiting requested review from lolodomo

@jlaur jlaur Awaiting requested review from jlaur

Assignees

@clinique clinique

Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[meteoalerte] Data frozen since May
5 participants
@clinique @openhab-bot @lolodomo @lsiepel @holgerfriedrich