Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[danfossairunit] Remove broken link from documentation #15528

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[danfossairunit] Remove broken link from documentation #15528

merged 2 commits into from
Sep 26, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Aug 31, 2023

No description provided.

@jlaur
Replace broken link
8f78fe5 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from pravussum as a code owner August 31, 2023 20:09
@jlaur jlaur changed the title [danfossairunit] Replace broken link [danfossairunit] Replace broken link in documentation Aug 31, 2023
pravussum
pravussum approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@pravussum pravussum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Sep 6, 2023

I just tested the new link but it leads to a page saying "We're sorry but we can't find the page you're looking for"

@jlaur
Copy link
Contributor Author

jlaur commented Sep 6, 2023 •
edited
Loading

I just tested the new link but it leads to a page saying "We're sorry but we can't find the page you're looking for"

OMG, you're right. They literally just took down that page since @pravussum approved. It existed until a few days ago. Thanks for checking, I'll see if I can find another page. I heard rumors that they are abandoning Danfoss Air.

EDIT: Maybe it's just a website maintenance job gone wrong - their own links are also broken:
https://www.danfoss.com/da-dk/search/?query=danfoss%20air&pageSize=10&filter=type%3Aproducts%2CdocumentationLanguage%3Ada_dk%2CdocumentationArchived%3Afalse -> second link for Danfoss Air a2 doesn't exist.

@jlaur jlaur marked this pull request as draft September 6, 2023 06:03
@jlaur
Copy link
Contributor Author

jlaur commented Sep 13, 2023

I have sent an inquiry to Danfoss. Currently you get the impression that these products never existed. I will send an update here when they get back to me.

@jlaur
Remove broken link and extend description
e110f29 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Copy link
Contributor Author

jlaur commented Sep 21, 2023

I have received an e-mail from Danfoss stating that they stopped selling all ventilation systems for homes per June 30th 2023. Therefore there are no replacement links.

@jlaur jlaur marked this pull request as ready for review September 21, 2023 20:35
@jlaur jlaur requested a review from a team September 21, 2023 20:37
@jlaur jlaur changed the title [danfossairunit] Replace broken link in documentation [danfossairunit] Remove broken link from documentation Sep 23, 2023
@lolodomo lolodomo merged commit afda8c5 into openhab:main Sep 26, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Sep 26, 2023
@jlaur jlaur deleted the danfossairunit-replace-broken-link branch September 28, 2023 21:30
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
@jlaur @Pshatsillo
[danfossairunit] Remove broken link from documentation (openhab#15528)
cce16af 
* Remove broken link and extend description

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@jlaur @pat-git023
[danfossairunit] Remove broken link from documentation (openhab#15528)
01fb07f 
* Remove broken link and extend description

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@jlaur @querdenker2k
[danfossairunit] Remove broken link from documentation (openhab#15528)
53c9fa7 
* Remove broken link and extend description

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@jlaur @querdenker2k
[danfossairunit] Remove broken link from documentation (openhab#15528)
ff835b6 
* Remove broken link and extend description

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
[danfossairunit] Remove broken link from documentation (openhab#15528)
e62c222 
* Remove broken link and extend description

---------

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@pravussum pravussum pravussum approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jlaur @lolodomo @pravussum