Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nanoleaf] Remove non-existing power channel from documentation #15570

Merged
merged 1 commit into from
Sep 23, 2023
Merged

[nanoleaf] Remove non-existing power channel from documentation #15570

merged 1 commit into from
Sep 23, 2023

Conversation

uqs
Copy link
Contributor

@uqs uqs commented Sep 9, 2023

Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Signed-off-by: uqs <uqs@FreeBSD.org>
@uqs uqs requested a review from stefan-hoehn as a code owner September 9, 2023 18:01
@lsiepel lsiepel changed the title Remove non-existing power channel [nanoleaf] Remove non-existing power channel from documentation Sep 9, 2023
@lolodomo
Copy link
Contributor

Let's wait for @stefan-hoehn confirmation, but yes I don't find any power channel after a very quick look.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is correct to remove the power info. It was already removed in March 2021. Thanks for catching this.

@lolodomo You can merge it.

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Sep 17, 2023
@stefan-hoehn stefan-hoehn self-requested a review September 17, 2023 19:15
@lolodomo lolodomo merged commit 7802a4a into openhab:main Sep 23, 2023
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Signed-off-by: uqs <uqs@FreeBSD.org>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Signed-off-by: uqs <uqs@FreeBSD.org>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Signed-off-by: uqs <uqs@FreeBSD.org>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Signed-off-by: uqs <uqs@FreeBSD.org>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.

Looks like documentation wasn't fully updated with the code changes.

Signed-off-by: uqs <uqs@FreeBSD.org>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants