-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nanoleaf] Remove non-existing power channel from documentation #15570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead. Looks like documentation wasn't fully updated with the code changes. Signed-off-by: uqs <uqs@FreeBSD.org>
lsiepel
changed the title
Remove non-existing power channel
[nanoleaf] Remove non-existing power channel from documentation
Sep 9, 2023
Let's wait for @stefan-hoehn confirmation, but yes I don't find any power channel after a very quick look. |
stefan-hoehn
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is correct to remove the power info. It was already removed in March 2021. Thanks for catching this.
@lolodomo You can merge it.
lolodomo
approved these changes
Sep 23, 2023
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead. Looks like documentation wasn't fully updated with the code changes. Signed-off-by: uqs <uqs@FreeBSD.org>
pat-git023
pushed a commit
to pat-git023/openhab-addons
that referenced
this pull request
Oct 13, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead. Looks like documentation wasn't fully updated with the code changes. Signed-off-by: uqs <uqs@FreeBSD.org>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead. Looks like documentation wasn't fully updated with the code changes. Signed-off-by: uqs <uqs@FreeBSD.org>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead. Looks like documentation wasn't fully updated with the code changes. Signed-off-by: uqs <uqs@FreeBSD.org> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead. Looks like documentation wasn't fully updated with the code changes. Signed-off-by: uqs <uqs@FreeBSD.org> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from OH 2.5 I tripped over this, as :power no longer exists and instead one has to send ON/OFF commands to the :color channel instead.
Looks like documentation wasn't fully updated with the code changes.