[chatgpt] Fix config option provider to only become active for chatgpt things #15578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
…penhab#15578) Signed-off-by: Kai Kreuzer <kai@openhab.org>
pat-git023
pushed a commit
to pat-git023/openhab-addons
that referenced
this pull request
Oct 13, 2023
…penhab#15578) Signed-off-by: Kai Kreuzer <kai@openhab.org>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
…penhab#15578) Signed-off-by: Kai Kreuzer <kai@openhab.org>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
…penhab#15578) Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
J-N-K
reviewed
Dec 29, 2023
| List<ParameterOption> options = new ArrayList<>(); | ||
| if (thingHandler instanceof ChatGPTHandler chatGPTHandler) { | ||
| chatGPTHandler.getModels().forEach(model -> options.add(new ParameterOption(model, model))); | ||
| String accountParameterUrl = "thing-type:" + ChatGPTBindingConstants.THING_TYPE_ACCOUNT.getAsString(); |
There was a problem hiding this comment.
This seems to be wrong. The model parameter is on a channel, not on the thing, so the uri is channel-type:chatgpt:chat
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…penhab#15578) Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15575