[MercedesMe] Switch to Mercedes App SDK

[weymann]

The current implementation of MercedesMe binding is based on Developer API from Mercedes. Unfortunately they quit supporting this on short hand notice end of August. Confirmed by me and recognized by the Community - binding is not working anymore!

New solution is based on Mercedes App SDK. Same as Homeassitant Mercedes integration which is still working.
This is a breaking change but it's needed to have this binding running again. I see no way Bridges and Vehicles can be reused due to different configurations.

[wborn]

I need advice how to exclude tool generated Google protobuf classes from checkstyle

IIRC we only check our own classes in the org.openhab package. So you can move generated or third party code to another package or add it to the suppressions.

[weymann]

@wborn
Moving protobuf classes out of org.openhab package doesn't work. Still get all errors

[ERROR] com.daimler.mbcarkit.proto.VehicleCommands.java:[6]
An author tag is missing

Maybe I should be more specific: It's generated sources, not directly class files.

[weymann]

Work in progress removed.
Binding looks pretty stable after testing by community

@openhab/maintainers still struggeling with proto java classes provided by Mercedes / Daimler which are causing many checkstyle issues.
I moved proto files to com.daimler.* package but checkstyle is still preventing a clean run
Resolved in latest commits

[wborn]

I had a look and currenty checkstyle is configured to check everything in src/main/java.

Some other add-ons have third party sources in src/3rdparty/java like flicbutton.
The build-helper-maven plugin is used in pom.xml to add those sources:

If that doesn't help, the last resort is to add a suppression for those packages in suppressions.xml.

[lsiepel]

@weymann this is marked as WIP for some time and that is perfectly fine. With 150+ changed files, it would take multiple review rounds i guss and some extensive testing to prevent regressions. Is there anything you need to proceed?

[weymann]

@weymann this is marked as WIP for some time and that is perfectly fine. With 150+ changed files, it would take multiple review rounds i guss and some extensive testing to prevent regressions. Is there anything you need to proceed?

Please check the initial comment of this PR.
Regression already took place at August 23 when Mercedes simply quit the support of the API.

Testing of this implementaion started Sep 23 here and there are ~80 comments afterwards which came into bugfixing.

WIP removed in comment from Nov 23 here

[lsiepel]

@weymann this is marked as WIP for some time and that is perfectly fine. With 150+ changed files, it would take multiple review rounds i guss and some extensive testing to prevent regressions. Is there anything you need to proceed?

Please check the initial comment of this PR. Regression already took place at August 23 when Mercedes simply quit the support of the API.
Testing of this implementaion started Sep 23 here and there are ~80 comments afterwards which came into bugfixing.

WIP removed in comment from Nov 23 here

It still has the WIP label. I’ll remove that. Once the conflicts are also solved a review can take place

[lolodomo]

163 000 lines of code !
Who will have the courage to start the review of such a big PR ?

[weymann]

163 000 lines of code ! Who will have the courage to start the review of such a big PR ?

@lolodomo Keep calm and start review!

code without comments and blank lines ~111K

• 3rdparty code
  ~100K which is generated protobuf code from daimler which shall not be reviewed!
  => https://github.com/mercedes-benz/MBSDK-CarKit-iOS
• binding code
  ~5K
• test code
  ~7K

[lsiepel]

Only the /build/gen/com/daimler/mbcarkit files are left to be moved.

[lsiepel]

Last one ^^

[lsiepel]

Thanks for the work on adapting this binding to the new Mercedes SDK.
LGTM.
Do you need some additional days to test before merge or is it well tested after all changes we made?

[weymann]

Do you need some additional days to test before merge or is it well tested after all changes we made?

You can leave it open for one or two weeks as you want, It's running on my machine and published on Marketplace. If I don't provide any more commits in this time it should be fine.
Most problematic issue reported during this review is solved and confirmed by the user.

[lsiepel]

Do you need some additional days to test before merge or is it well tested after all changes we made?

You can leave it open for one or two weeks as you want, It's running on my machine and published on Marketplace. If I don't provide any more commits in this time it should be fine. Most problematic issue reported during this review is solved and confirmed by the user.

Oke, will do. Could you create a upgrade warning in openHAB/distro ?

https://github.com/openhab/openhab-distro/blob/328f2a34fc0c1f5ae492b9ecad89fc613fa63f69/distributions/openhab/src/main/resources/bin/update.lst

[weymann]

Oke, will do. Could you create a upgrade warning in openHAB/distro ?

Please assist.
As stated in PR description public Mercedes Me API isn't available anymore. So there's no way to avoid these changes. What shall I document besides readme chnages?

[lsiepel]

Oke, will do. Could you create a upgrade warning in openHAB/distro ?

Please assist. As stated in PR description public Mercedes Me API isn't available anymore. So there's no way to avoid these changes. What shall I document besides readme chnages?

It is an extra (more active) notice so that users are aware they have to adapt their configuration. Recreate Thing and or update item channel links. This is not a drop in replacement

[lsiepel]

This one slipped through.

[lsiepel]

From my understanding there should not be any changes to this file from this PR. You can manually save/backup the file and manually upload it after this PR is merged into crowdin.

[weymann]

This one slipped through.

Yes, I messed up previous revert - some special charachters were destroyed while copy/paste. Took now original file from main branch and pushed it. Now file isn't listed any longer in file changes

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mercedes-me-binding/136852/206