Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Karaf 4.4.4 #15659

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Upgrade to Karaf 4.4.4 #15659

merged 1 commit into from
Sep 30, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Sep 27, 2023

  • Resolve itest runbundles
  • Fix dependency issues
  • Add specs features because Pax Web now depends on "asm"

Depends on openhab/openhab-core#3814

@wborn
Upgrade to Karaf 4.4.4
c0224f1 
* Resolve itest runbundles
* Fix dependency issues
* Add specs features because Pax Web now depends on "asm"

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the awaiting other PR Depends on another PR label Sep 27, 2023
hmerk
hmerk approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Wemo

J-N-K
J-N-K approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added about to close Issue potentially resolved and no feedback received rebuild Triggers Jenkins PR build and removed about to close Issue potentially resolved and no feedback received rebuild Triggers Jenkins PR build labels Sep 29, 2023
@J-N-K J-N-K merged commit 9d03ec9 into openhab:main Sep 30, 2023
@J-N-K J-N-K added this to the 4.1 milestone Sep 30, 2023
@wborn wborn deleted the karaf-4.4.4 branch September 30, 2023 06:09
wborn added a commit to wborn/openhab-addons that referenced this pull request Oct 8, 2023
@wborn
[jdbc] Fix logging not working
f451519 
The dependency change in openhab#15659 caused slf4j to be embedded into the bundle.

As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Oct 8, 2023
Merged
jlaur pushed a commit that referenced this pull request Oct 8, 2023
@wborn
[jdbc] Fix logging not working (#15722)
756b32d 
The dependency change in #15659 caused slf4j to be embedded into the bundle.

As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn removed the awaiting other PR Depends on another PR label Oct 8, 2023
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@wborn @pat-git023
Upgrade to Karaf 4.4.4 (openhab#15659)
8f04e56 
* Resolve itest runbundles
* Fix dependency issues
* Add specs features because Pax Web now depends on "asm"

Signed-off-by: Wouter Born <github@maindrain.net>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@wborn @pat-git023
[jdbc] Fix logging not working (openhab#15722)
4936981 
The dependency change in openhab#15659 caused slf4j to be embedded into the bundle.

As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Signed-off-by: Wouter Born <github@maindrain.net>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@wborn @querdenker2k
Upgrade to Karaf 4.4.4 (openhab#15659)
49dfc16 
* Resolve itest runbundles
* Fix dependency issues
* Add specs features because Pax Web now depends on "asm"

Signed-off-by: Wouter Born <github@maindrain.net>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@wborn @querdenker2k
[jdbc] Fix logging not working (openhab#15722)
917d60d 
The dependency change in openhab#15659 caused slf4j to be embedded into the bundle.

As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Signed-off-by: Wouter Born <github@maindrain.net>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@wborn @querdenker2k
Upgrade to Karaf 4.4.4 (openhab#15659)
899c4f6 
* Resolve itest runbundles
* Fix dependency issues
* Add specs features because Pax Web now depends on "asm"

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@wborn @querdenker2k
[jdbc] Fix logging not working (openhab#15722)
ca059ab 
The dependency change in openhab#15659 caused slf4j to be embedded into the bundle.

As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@wborn @austvik
Upgrade to Karaf 4.4.4 (openhab#15659)
36e9294 
* Resolve itest runbundles
* Fix dependency issues
* Add specs features because Pax Web now depends on "asm"

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@wborn @austvik
[jdbc] Fix logging not working (openhab#15722)
42e6625 
The dependency change in openhab#15659 caused slf4j to be embedded into the bundle.

As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@hmerk hmerk hmerk approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@svilenvul svilenvul Awaiting requested review from svilenvul

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@wborn @J-N-K @hmerk