[velbus] New functionality and bug fix #15661

Rosen01 · 2023-09-27T21:40:51Z

New functionality :

Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (fixes [Velbus] Add the relay / OP channel of the Edge Lit panels #14179)
Add module VMBDALI. (fixes [Velbus] feature request - VMBDALI #14654)
Add modules : VMB4RYLD-10, VMB4RYNO-10, VMB2BLE-10, VMB6PB-20, VMBEL1-20, VMBEL2-20, VMBEL4-20, VMBELO-20, VMBGP1-20, VMBGP2-20, VMBGP4-20, VMBGPO-20, VMBDALI-20, VMBEL4PIR-20, VMBGP4PIR-20

Fix bug :

No access to sub-address modules when adding manually the modules : VMBELO, VMBGPO, VMBGPOD, VMBGPOD-2 (fixes [Velbus] Button Modules with multiple adressess not fully working #12702)
Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD-2.
Wrong typeId for bridge alarms management.
Trigger all the channels present in a packet. (bug reported here)

Signed-off-by: Daniel Rosengarten github@praetorians.be

New functionnality : - Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (openhab#14179) - Add module VMBDALI. (openhab#14654) Fix bug : - No access to sub-address modules when adding manually the modules : VMBELO,VMBGPO, VMBGPOD, VMBGPOD-2 (openhab#12702) - Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD_2. - Wrong typeId for bridge alarms management. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

openhab-bot · 2023-09-28T05:56:29Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/velbus-vmbpirm-only-ch3-supported/147834/4

Changed the management of VMBDALI white channel. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

nagisa

Initial pass, still didn’t look at VMBDALI and need more time to grok subaddress changes.

...binding.velbus/src/main/java/org/openhab/binding/velbus/internal/VelbusBindingConstants.java

bundles/org.openhab.binding.velbus/README.md

bundles/org.openhab.binding.velbus/src/main/resources/OH-INF/config/config.xml

...ng.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMBELOHandler.java

...ing.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMBELHandler.java

....velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMBMeteoHandler.java

...ing.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusThingHandler.java

...src/main/java/org/openhab/binding/velbus/internal/discovery/VelbusThingDiscoveryService.java

nagisa

Reviewed the rest of this. Thanks for going through the implementation effort here (I’m sure people will appreciate it when this finally lands.)

As a broader comment, I truly wonder if having VirtualLight be configured through a parameter on VMBDALI is the right thing. My view of this is that making it a proper thing (perhaps a child of the VMBDALI Thing, much like VMBDALI is itself a child of the network bridge) would make it much much easier to expand the concept in the future if the need arised. Now with VL=CH1,CH2,CH3,CH4 configuration that's pretty much the extent that can exist. If we wanted to add additional functionality that requires configuration, we wouldn’t be able to do so without introducing a breaking change.

...ding.velbus/src/main/java/org/openhab/binding/velbus/internal/VelbusVirtualColorChannel.java

...hab.binding.velbus/src/main/java/org/openhab/binding/velbus/internal/VelbusColorChannel.java

nagisa · 2023-09-30T18:10:43Z

One thing to keep in mind as you peruse my review comments: I haven’t contributed to OpenHAB code in the past (so e.g. my knowledge of conventions in this project is non-existent), and the last time I have written any Java was also many, many years ago (so my knowledge of conventions in this entire ecosystem are also non-existent.)

If the comments don’t make sense or they suggest to do something the wrong way around, feel free to simply resolve that comment and forget ever seeing it :)

…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

…inding/velbus/internal/discovery/VelbusThingDiscoveryService.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

* VelbusVirtualColorChannel class Permits different values (CH0 or A0) to configure the virtual light's channels. * VelbusColorChannel class Makes color transformation easy with the rescale function. * onPacketReceived interface Stops processing packets when handler is disposed. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

...src/main/java/org/openhab/binding/velbus/internal/discovery/VelbusThingDiscoveryService.java

nagisa · 2023-10-05T15:39:17Z

This looks really nice so far. Unfortunately I haven’t the capabilities to help with driving the PR further. Hopefully my reviews have been helpful and whenever somebody with merge button powers comes along, they’ll be happy enough with the changes to be able to press it without further questions :)

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

lsiepel

As the thing configuration has been altered, i think it would be needed to add thing upgrade instructions:
https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

Thing upgrade instructions for VMBEL1, VMBEL2, VMBEL4, VMBELO. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Added missing bundle reference in channel type. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Rosen01 · 2024-01-30T15:42:51Z

@cedricboon is there any chance you find time to check the code and accept the pull request ?

Rosen01 · 2024-03-08T13:04:42Z

It seems that @cedricboon has no time to do the review.
It would be nice if a maintainer (@lsiepel, @jlaur, @lolodomo, @fwolter) can review and, if it's OK, merge this pull request.

Disable push button events on sensor address for new modules *-20. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

lsiepel

Thanks, left some comments. Overall it looks good, thanks for the fixes. Hopefully future PR's are a bit smaller :-)

bundles/org.openhab.binding.velbus/README.md

...ing.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMBELHandler.java

...ng.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMBELOHandler.java

...ing.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusThingHandler.java

...g.velbus/src/main/java/org/openhab/binding/velbus/internal/handler/VelbusVMBDALIHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

…inding/velbus/internal/handler/VelbusVMBELHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

…inding/velbus/internal/handler/VelbusVMBELOHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

…inding/velbus/internal/handler/VelbusVMBDALIHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

lsiepel

Thanks, LGTM

* [velbus] New functionnality & Bug fix Signed-off-by: Daniel Rosengarten <github@praetorians.be> Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Co-authored-by: lsiepel <leosiepel@gmail.com>

* [velbus] New functionnality & Bug fix Signed-off-by: Daniel Rosengarten <github@praetorians.be> Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

* [velbus] New functionnality & Bug fix Signed-off-by: Daniel Rosengarten <github@praetorians.be> Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>

* [velbus] New functionnality & Bug fix Signed-off-by: Daniel Rosengarten <github@praetorians.be> Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Co-authored-by: lsiepel <leosiepel@gmail.com>

Rosen01 requested a review from cedricboon as a code owner September 27, 2023 21:40

[velbus] VMBDALI white channel

d25e053

Changed the management of VMBDALI white channel. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

lsiepel added the enhancement An enhancement or new feature for an existing add-on label Sep 30, 2023

nagisa reviewed Sep 30, 2023

View reviewed changes

wborn changed the title ~~[velbus] New functionnality & Bug fix~~ [velbus] New functionality and bug fix Oct 2, 2023

Rosen01 and others added 13 commits October 4, 2023 09:27

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

f3143c3

…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

37b72b2

…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/README.md

fb2ee80

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/README.md

f3565df

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

1196489

…inding/velbus/internal/discovery/VelbusThingDiscoveryService.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/README.md

215c6ac

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/README.md

817c8c7

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/README.md

b49bd66

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Merge branch 'openhab:main' into main

77f3005

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

025684c

…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

5d76cc4

…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

0d29715

…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

nagisa reviewed Oct 5, 2023

View reviewed changes

...src/main/java/org/openhab/binding/velbus/internal/discovery/VelbusThingDiscoveryService.java Outdated Show resolved Hide resolved

nagisa approved these changes Oct 5, 2023

View reviewed changes

[velbus] small correction

6f5c9e5

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

lsiepel requested a review from a team November 12, 2023 19:42

lsiepel reviewed Nov 13, 2023

View reviewed changes

Rosen01 and others added 2 commits November 14, 2023 12:14

Merge branch 'openhab:main' into main

f539895

[velbus] Add thing upgrade instructions VMBELx

1be6169

Thing upgrade instructions for VMBEL1, VMBEL2, VMBEL4, VMBELO. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Rosen01 and others added 4 commits January 17, 2024 23:24

[velbus] Copyright update

13aea1e

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Merge branch 'openhab:main' into main

75352b0

Merge branch 'openhab:main' into main

40cbed0

[velbus] Fix update instructions

89c04aa

Added missing bundle reference in channel type. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Rosen01 added 4 commits February 13, 2024 11:05

Merge branch 'openhab:main' into main

a02016e

Merge branch 'openhab:main' into main

b54ca33

Merge branch 'openhab:main' into main

bf0ac9e

Merge branch 'openhab:main' into main

15c950a

Rosen01 and others added 4 commits March 24, 2024 22:30

Merge branch 'openhab:main' into main

9e2b724

Merge branch 'openhab:main' into main

f6f9a9b

[velbus] Disable push button events on sensor address for new modules

58ac264

Disable push button events on sensor address for new modules *-20. Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Merge branch 'openhab:main' into main

7afc5ff

lsiepel requested changes Apr 27, 2024

View reviewed changes

Rosen01 and others added 7 commits April 28, 2024 21:39

Update bundles/org.openhab.binding.velbus/README.md

e978b29

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

3e68197

…inding/velbus/internal/handler/VelbusVMBELHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

296b229

…inding/velbus/internal/handler/VelbusVMBELOHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

ff2a1b2

…inding/velbus/internal/handler/VelbusVMBDALIHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Update bundles/org.openhab.binding.velbus/src/main/java/org/openhab/b…

9eda049

…inding/velbus/internal/handler/VelbusVMBDALIHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Daniel Rosengarten <rosengarten01@hotmail.com>

Merge branch 'openhab:main' into main

29c5224

Update VelbusVMBDALIHandler.java

5fe388c

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

lsiepel merged commit bd2dcba into openhab:main Apr 28, 2024
5 checks passed

lsiepel reviewed Apr 28, 2024

View reviewed changes

lsiepel added this to the 4.2 milestone Apr 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[velbus] New functionality and bug fix #15661

[velbus] New functionality and bug fix #15661

Rosen01 commented Sep 27, 2023 •

edited

Loading

openhab-bot commented Sep 28, 2023

nagisa left a comment

nagisa left a comment •

edited

Loading

nagisa commented Sep 30, 2023

nagisa commented Oct 5, 2023

lsiepel left a comment

Rosen01 commented Jan 30, 2024

Rosen01 commented Mar 8, 2024

lsiepel left a comment

lsiepel left a comment

[velbus] New functionality and bug fix #15661

[velbus] New functionality and bug fix #15661

Conversation

Rosen01 commented Sep 27, 2023 • edited Loading

openhab-bot commented Sep 28, 2023

nagisa left a comment

Choose a reason for hiding this comment

nagisa left a comment • edited Loading

Choose a reason for hiding this comment

nagisa commented Sep 30, 2023

nagisa commented Oct 5, 2023

lsiepel left a comment

Choose a reason for hiding this comment

Rosen01 commented Jan 30, 2024

Rosen01 commented Mar 8, 2024

lsiepel left a comment

Choose a reason for hiding this comment

lsiepel left a comment

Choose a reason for hiding this comment

Rosen01 commented Sep 27, 2023 •

edited

Loading

nagisa left a comment •

edited

Loading