Improve javadoc for all addons #15667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken references, syntax errors. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
requested review from
gerrieg,
JochenHiller,
lolodomo,
kaikreuzer,
gbicskei,
a team,
jlaur,
clinique,
lujop,
ssalonen,
tmrobert8,
davidgraeff,
digitaldan,
andylintner,
ccutrer,
yfre,
zarusz,
coop-git,
pavel-gololobov,
BoBiene,
hmerk,
mhilbush,
mlobstein,
steand,
jannegpriv,
hww3,
gs4711,
andrewfg and
MatthiasKlocke
as code owners
holgerfriedrich
requested review from
trokohl,
pfink,
Andy2003,
Nebula83,
fruggy83,
limdul79 and
DerOetzi
as code owners
lsiepel
approved these changes
Sep 30, 2023
jlaur
requested changes
Sep 30, 2023
...e/src/main/java/org/openhab/binding/energidataservice/internal/retry/RetryPolicyFactory.java
Outdated
Show resolved
Hide resolved
lolodomo
reviewed
Sep 30, 2023
...g.openhab.binding.sonos/src/main/java/org/openhab/binding/sonos/internal/SonosXMLParser.java
Outdated
Show resolved
Hide resolved
|
Except sonos binding, changes in astro, freebox, freeboxos, lgwebos, netatmo, ntp, powermax, pulseaudio, sonyprojector, weatherunderground looks fine to me. I have not checked the changes in other bindings. |
janvyb
approved these changes
Sep 30, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
requested review from
RSStephens,
andrew-schofield,
Friesoch,
soenkekueper,
jwveldhuis and
rs22
as code owners
GiviMAD
approved these changes
Sep 30, 2023
pat-git023
pushed a commit
to pat-git023/openhab-addons
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javadoc was quite broken form most of the addons.
This PR fixes most of the errors the javadoc run is reporting.
Sorry for bothering almost everybody with this review request.