[sensorcommunity] State pattern for dB, Percent and Microgram/m3 added #15692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
jlaur
requested changes
Oct 4, 2023
...g.sensorcommunity/src/test/java/org/openhab/binding/sensorcommunity/internal/NumberTest.java
Outdated
Show resolved
Hide resolved
lolodomo
reviewed
Oct 14, 2023
bundles/org.openhab.binding.sensorcommunity/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
|
So for me this PR is OK regarding the changes on state pattern. I did not look at tests as @jlaur already commented. |
lolodomo
added
the
enhancement
|
@jlaur : I let you the lead on the merge of this PR. |
|
@weymann : can you please look at review comments so that your PR can be merged please. |
lolodomo
added
the
awaiting feedback
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
weymann
force-pushed
the
sensorcommunity-state-patterns
branch
from
fdfda11 to
acda68d
Compare
Done |
lolodomo
removed
the
awaiting feedback
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
openhab#15692) * State pattern for dB, Percent and Microgram/m3 added --------- Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
openhab#15692) * State pattern for dB, Percent and Microgram/m3 added --------- Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State pattern for dB, Percent and Microgram/m3 added