[ipcamera] Handle empty snapshotUrls and XML encoded characters #15707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
|
Let's give a chance to @Skinah to review. |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
rebuild
|
LGTM, thanks for PR. |
|
@kaikreuzer : a conflict has to be resolved before I can merge. |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
@lolodomo: Conflicts resolved. |
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
…hab#15707) * [ipcamera] Handle empty snapshotUrls and XML encoded characters * use unescape method from StringUtils --------- Signed-off-by: Kai Kreuzer <kai@openhab.org>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
…hab#15707) * [ipcamera] Handle empty snapshotUrls and XML encoded characters * use unescape method from StringUtils --------- Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…hab#15707) * [ipcamera] Handle empty snapshotUrls and XML encoded characters * use unescape method from StringUtils --------- Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My ONVIF camera does not provide a snapshotUrl and the binding crashed when trying to parse the empty url.
Additionally, the rtsp url contains an
&, which is XML encoded and needs to be decoded first.Both issues are fixed by this PR.