Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonos] Add Dolby Digital Plus 2.0 and fix Dolby Digital 2.0 #15712

Merged
merged 1 commit into from
Oct 7, 2023
Merged

[sonos] Add Dolby Digital Plus 2.0 and fix Dolby Digital 2.0 #15712

merged 1 commit into from
Oct 7, 2023

Conversation

morph166955
Copy link
Contributor

Adds Dolby Digital Plus 2.0 and a second codec ID for Dolby Digital 2.0.

Resolves #15643

@morph166955
Adds DDPlus20 and an additional ID for DD20
f1660bb 
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
@jlaur jlaur changed the title Adds DDPlus20 and an additional ID for DD20 [sonos] Adds DDPlus20 and an additional ID for DD20 Oct 6, 2023
@jlaur jlaur changed the title [sonos] Adds DDPlus20 and an additional ID for DD20 [sonos] Add Dolby Digital Plus 2.0 and fix Dolby Digital 2.0 Oct 7, 2023
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Oct 7, 2023
lolodomo
lolodomo approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 40d5bb3 into openhab:main Oct 7, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Oct 7, 2023
@morph166955 morph166955 deleted the sonos-codec branch October 8, 2023 02:42
@morph166955
Copy link
Contributor Author

LGTM, thank you

No problemo.

pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@morph166955 @pat-git023
Adds DDPlus20 and an additional ID for DD20 (openhab#15712)
c33781f 
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@morph166955 @querdenker2k
Adds DDPlus20 and an additional ID for DD20 (openhab#15712)
0036bf0 
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@morph166955 @querdenker2k
Adds DDPlus20 and an additional ID for DD20 (openhab#15712)
6a12418 
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@morph166955 @austvik
Adds DDPlus20 and an additional ID for DD20 (openhab#15712)
65f7b69 
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[sonos] Missing Codecs
3 participants
@morph166955 @lolodomo @jlaur