[tapocontrol] Add klap-protocol to support multiple new devices #15725

wildcs · 2023-10-09T13:41:15Z

Tapocontrol-Binding for Tapo-Devices

this pr is necesarry because manufacturer changed communication protocol for some devices so device-communication is broken.
because the communication changed i decided to revise the whole code of the plugin.

this pr has more changes:

complete code revision
integration new "klap-protocol"
integration local device discovery with udp
integration "H100 Smart-Hub"
integration "T110 door-/window-contact sensor"
integration "T310/T315 wheateher- sensors"
supporting light-effects for light-strips

clinique

Nice rework. Thanks for this !

bundles/org.openhab.binding.tapocontrol/pom.xml

...ol/src/main/java/org/openhab/binding/tapocontrol/internal/api/protocol/TapoProtocolEnum.java

...c/main/java/org/openhab/binding/tapocontrol/internal/api/protocol/TapoProtocolInterface.java

...rol/src/main/java/org/openhab/binding/tapocontrol/internal/api/protocol/klap/KlapCipher.java

...l/src/main/java/org/openhab/binding/tapocontrol/internal/api/protocol/klap/KlapProtocol.java

...a/org/openhab/binding/tapocontrol/internal/api/protocol/passthrough/PassthroughProtocol.java

...g/openhab/binding/tapocontrol/internal/api/protocol/securePassthrough/SecurePassthrough.java

...src/main/java/org/openhab/binding/tapocontrol/internal/devices/bridge/TapoBridgeHandler.java

clinique

A small review pass.

...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java

...pocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/api/TapoCloudConnector.java

...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java

...trol/src/main/java/org/openhab/binding/tapocontrol/internal/devices/dto/TapoLightEffect.java

...rc/main/java/org/openhab/binding/tapocontrol/internal/devices/rf/TapoChildDeviceHandler.java

clinique

LGTM

openhab-bot · 2023-11-14T07:16:27Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tapocontrol-control-tapo-smart-wifi-devices-with-openhab-official-support-thread/118389/338

lsiepel · 2023-11-23T22:53:04Z

@wildcs can you fix the conflict?

wildcs · 2023-11-25T09:52:08Z

@wildcs can you fix the conflict?

@lsiepel Can youn tell me how? The code has changed completeley. The old file has to be overwritten by the new one file. I dont have write access to do this

wildcs · 2023-12-02T08:16:28Z

Can someone else help to resolve the conflict?
@clinique @lolodomo maybe?

clinique · 2023-12-02T08:17:57Z

Can someone else help to resolve the conflict?
@clinique @lolodomo maybe?

You need to rebase your PR and force push, it should do it.

Signed-off-by: Christian Wild <christian@wildclan.de>

code revision - fix P300 and L9x0 devices Signed-off-by: Christian Wild <christian@wildclan.de>

code revision - light-effects for lightstrips added Signed-off-by: Christian Wild <christian@wildclan.de>

complete code revision udp-discovery added light-effects for lightstrips added Signed-off-by: Christian Wild <christian@wildclan.de>

complete code revision udp-discovery added light-effects for lightstrips added code review Signed-off-by: Christian Wild <christian@wildclan.de>

Signed-off-by: Christian Wild <christian@wildclan.de>

wildcs · 2024-04-23T19:57:01Z

@lsiepel
Thanks for your review. Did a rebase and fixed your request.
Hope it now can be merged soon.

clinique · 2024-04-27T23:34:27Z

@holgerfriedrich : can you please push on having it merged soon ? Thanks a lot.

lsiepel

Thanks, LGTM

dor-bw · 2024-04-28T08:29:14Z

Thank you very much! All good things are worth waiting for.

…penhab#15725) * [tapocontrol] new tapo klap-protocol integration Signed-off-by: Christian Wild <christian@wildclan.de>

nelsonaponte · 2024-04-30T17:54:54Z

Thank you very much! All good things are worth waiting for.

That’s one funny way to end this drama 😅

@wildcs, thanks for not giving up!
@clinique and @lsiepel, thanks for your support!

giig1967g · 2024-04-30T18:05:37Z

In which version will we see the new Tapo binding?

lsiepel · 2024-04-30T21:02:07Z

In which version will we see the new Tapo binding?

Daily snapshot, next milestone 4.2.0.M3 or next stable 4.2.0

openhab-bot · 2024-05-20T16:15:54Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/131

…penhab#15725) * [tapocontrol] new tapo klap-protocol integration Signed-off-by: Christian Wild <christian@wildclan.de> Signed-off-by: Paul Smedley <paul@smedley.id.au>

…penhab#15725) * [tapocontrol] new tapo klap-protocol integration Signed-off-by: Christian Wild <christian@wildclan.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>

…penhab#15725) * [tapocontrol] new tapo klap-protocol integration Signed-off-by: Christian Wild <christian@wildclan.de>

…penhab#15725) * [tapocontrol] new tapo klap-protocol integration Signed-off-by: Christian Wild <christian@wildclan.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>

wildcs force-pushed the tapocontrol branch 2 times, most recently from 9fc3562 to 41e61c9 Compare October 9, 2023 13:57

jlaur linked an issue Oct 9, 2023 that may be closed by this pull request

[Tapocontrol] Unable to control L530 after upgrade to 1.1.0 Build 230721 #15503

Closed

wildcs force-pushed the tapocontrol branch 5 times, most recently from b7ada83 to 54c5914 Compare October 10, 2023 19:45

This was referenced Oct 12, 2023

[tapocontrol] Problem commanding Tapo P300 Power Strip channels because of min_gap #15717

Closed

[tapocontrol] Tapo Things offline since firmware update #15585

Closed

jlaur linked an issue Oct 12, 2023 that may be closed by this pull request

[tapocontrol] Problem commanding Tapo P300 Power Strip channels because of min_gap #15717

Closed

lolodomo added the enhancement An enhancement or new feature for an existing add-on label Oct 14, 2023

clinique requested changes Oct 26, 2023

View reviewed changes

wildcs force-pushed the tapocontrol branch from 5839762 to b459f6e Compare November 1, 2023 14:39

wildcs requested a review from clinique November 1, 2023 15:03

wildcs force-pushed the tapocontrol branch 3 times, most recently from 4e7e0b8 to 9834cea Compare November 1, 2023 16:21

clinique requested changes Nov 1, 2023

View reviewed changes

wildcs requested a review from clinique November 3, 2023 04:56

clinique approved these changes Nov 3, 2023

View reviewed changes

wildcs force-pushed the tapocontrol branch from 924f66c to 55b2e54 Compare November 4, 2023 19:09

lsiepel requested a review from a team November 23, 2023 22:52

wildcs force-pushed the tapocontrol branch from 55b2e54 to eeff5ff Compare November 25, 2023 09:39

wildcs force-pushed the tapocontrol branch from eeff5ff to 6b180b2 Compare December 2, 2023 14:59

wildcs added 10 commits April 23, 2024 09:17

[tapocontrol] fix lightningeffects for lightstrips (readonly)

6fb7a26

Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] KLAP-Protocol integration

dd9f10d

code revision - fix P300 and L9x0 devices Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] KLAP-Protocol integration

34f6725

code revision - light-effects for lightstrips added Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] KLAP-Protocol integration

f80706f

complete code revision udp-discovery added light-effects for lightstrips added Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] KLAP-Protocol integration

3e9f2a2

complete code revision udp-discovery added light-effects for lightstrips added code review Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] code reviews

f5d30a8

Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] rebase to upstream and bugfixes

48ce196

Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] changed readme for fixing review

ef0173d

Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] code review changes

c48e698

Signed-off-by: Christian Wild <christian@wildclan.de>

[tapocontrol] rebase and fix requested changes

a3d7ae0

Signed-off-by: Christian Wild <christian@wildclan.de>

wildcs force-pushed the tapocontrol branch from bb032f2 to a3d7ae0 Compare April 23, 2024 07:41

wildcs requested a review from lsiepel April 23, 2024 07:47

lsiepel approved these changes Apr 28, 2024

View reviewed changes

lsiepel merged commit dbe9709 into openhab:main Apr 28, 2024
5 checks passed

lsiepel added this to the 4.2 milestone Apr 28, 2024

lsiepel changed the title ~~[tapocontrol] new communication protocol integration / code revision~~ [tapocontrol] Add klap-protocol to support multiple new devices Apr 28, 2024

wildcs deleted the tapocontrol branch May 29, 2024 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tapocontrol] Add klap-protocol to support multiple new devices #15725

[tapocontrol] Add klap-protocol to support multiple new devices #15725

wildcs commented Oct 9, 2023 •

edited

Loading

clinique left a comment

clinique left a comment

clinique left a comment

openhab-bot commented Nov 14, 2023

lsiepel commented Nov 23, 2023

wildcs commented Nov 25, 2023 •

edited

Loading

wildcs commented Dec 2, 2023

clinique commented Dec 2, 2023

wildcs commented Apr 23, 2024

clinique commented Apr 27, 2024

lsiepel left a comment

dor-bw commented Apr 28, 2024

nelsonaponte commented Apr 30, 2024

giig1967g commented Apr 30, 2024

lsiepel commented Apr 30, 2024

openhab-bot commented May 20, 2024

[tapocontrol] Add klap-protocol to support multiple new devices #15725

[tapocontrol] Add klap-protocol to support multiple new devices #15725

Conversation

wildcs commented Oct 9, 2023 • edited Loading

clinique left a comment

Choose a reason for hiding this comment

clinique left a comment

Choose a reason for hiding this comment

clinique left a comment

Choose a reason for hiding this comment

openhab-bot commented Nov 14, 2023

lsiepel commented Nov 23, 2023

wildcs commented Nov 25, 2023 • edited Loading

wildcs commented Dec 2, 2023

clinique commented Dec 2, 2023

wildcs commented Apr 23, 2024

clinique commented Apr 27, 2024

lsiepel left a comment

Choose a reason for hiding this comment

dor-bw commented Apr 28, 2024

nelsonaponte commented Apr 30, 2024

giig1967g commented Apr 30, 2024

lsiepel commented Apr 30, 2024

openhab-bot commented May 20, 2024

wildcs commented Oct 9, 2023 •

edited

Loading

wildcs commented Nov 25, 2023 •

edited

Loading