[neohub] Avoid too frequent requests to hub #15743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@andrewfg : still really work in progress ? |
@lolodomo yes, unfortunately; I have been running it 7/24 and the PR seems not to solve the issue. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@lolodomo this one is good to go now :) |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [neohub] throttle requests to hub * [neohub] handle websocket error; and attempt restart --------- Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* [neohub] throttle requests to hub * [neohub] handle websocket error; and attempt restart --------- Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The NeoHub bridge thing sometimes goes offline due to systemTimeout. Discussions on the Heatmiser developer forum indicate that this error may be due to the binding making requests too fast.
https://dev.heatmiser.com/t/need-help-with-neohub-spuriously-changing-thermostat-settings/818/1
Solution
The solution is to pipeline the requests and throttle them.
Fixes #15498
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch