Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilight] Fix background discovery #15791

Merged

Conversation

stefanroellin
Copy link
Contributor

If there were multiple network interfaces and the DatagramSocket.receive timed out an exception was thrown and the remaining network interfaces were not considered anymore.

@stefanroellin stefanroellin force-pushed the pilight-fix-background-discovery branch 2 times, most recently from 78bbca9 to 663a1af Compare October 21, 2023 10:10
…aces

If there were multiple network interfaces and the DatagramSocket.receive
timed out an exception was thrown and the remaining network interfaces
were not considered anymore.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
@stefanroellin stefanroellin force-pushed the pilight-fix-background-discovery branch from 663a1af to 34c5401 Compare October 21, 2023 10:17
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Oct 22, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit b503382 into openhab:main Nov 3, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 3, 2023
@stefanroellin stefanroellin deleted the pilight-fix-background-discovery branch November 3, 2023 18:44
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
…aces (openhab#15791)

If there were multiple network interfaces and the DatagramSocket.receive
timed out an exception was thrown and the remaining network interfaces
were not considered anymore.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…aces (openhab#15791)

If there were multiple network interfaces and the DatagramSocket.receive
timed out an exception was thrown and the remaining network interfaces
were not considered anymore.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants