[saicismart] Initial contribution

[dougculnane]

This PR is a revival of the PR here: #13573

I have updated for openHAB 4. The binding runs but needs some more testing, documentation etc...

[dougculnane]

Summary
Commit sha: a50c49f, Author: Markus Heberling, Committer: dougculnane; The sign-off is missing.
Commit sha: bb94376, Author: Markus Heberling, Committer: dougculnane; The sign-off is missing.
Commit sha: e38ba38, Author: Markus Heberling, Committer: dougculnane; The sign-off is missing.
Commit sha: 1502e8c, Author: Markus Heberling, Committer: dougculnane; The sign-off is missing.

@tisoft these commits do not have a --signoff. So I think I can not get your code into openhab without claiming it as mine (which I do not want to do).... Are you able to checkout this branch and rebase it and signoff? I am happy for you to claim my code as yours and then I can complete the PR, or we can work on this together to get it done.

[tisoft]

I will have a look. Thanks for taking this over. :)

[dougculnane]

I will have a look. Thanks for taking this over. :)

I invited you to my repo: https://github.com/dougculnane/openhab-addons so you can push to it.

I think you can do this:
"
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~38 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin saic-ismart-openhab4
"

Then I can update the PR and try to get it merge ready.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-binding-integration-of-saic-mg-ismart-based-vehicles/140136/31

[dougculnane]

I have been testing this and it works (but I think my car has some connectivity problems in the valley where I live...)

The AC on works.
The info is good and updates.
The force refresh works.

So this is usable for home energy automation and information. Also it is great to be able to pre-warm the car in the mornings...

I will do more testing and fixing as needed but I think this is ready for a review and feedback.

[tisoft]

I think the security code can be removed completely. All Interactions that need it in the official App, don't seem to need it when called directly by the API. The MQTT bindings don't use it either.

[dougculnane]

I think the security code can be removed completely. All Interactions that need it in the official App, don't seem to need it when called directly by the API. The MQTT bindings don't use it either.

Thanks for the feedback Markus. I was having update issues but I think this is due to car <-> mg-server connection issues. Sending the PIN seamed to help but maybe it was a change in the weather... I will remove this and test it. If we do not need it then I will get rid of it.

Thanks again.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/volvo-oncall-binding/59605/132

[lsiepel]

Went through the last files and changes. Left some comments related to status updates, i18n and minor code improvements. Allmost there.

[lsiepel]

Two comments left.

[lsiepel]

Thanks for you contribution! LGTM

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website