-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt] Interpet incoming NaN as UNDEF for NumberValues #15897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since DecimalType and QuantityType don't support NaN, but when you're linking to a topic that the device is using floating point, NaN might happen. Signed-off-by: Cody Cutrer <cody@cutrer.us>
@antroids: this is actually coming from a Home Assistant compatible device (ESPHome) |
antroids
requested changes
Dec 4, 2023
...penhab.binding.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/ChannelState.java
Show resolved
Hide resolved
Signed-off-by: Cody Cutrer <cody@cutrer.us>
antroids
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
lolodomo
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
lolodomo
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Dec 10, 2023
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [mqtt] Interpet incoming NaN as UNDEF for NumberValues Since DecimalType and QuantityType don't support NaN, but when you're linking to a topic that the device is using floating point, NaN might happen. --------- Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* [mqtt] Interpet incoming NaN as UNDEF for NumberValues Since DecimalType and QuantityType don't support NaN, but when you're linking to a topic that the device is using floating point, NaN might happen. --------- Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DecimalType and QuantityType don't support NaN, but when you're linking to a topic that the device is using floating point, NaN might happen.