[thekeys] Initial contribution #16037

JordanMartin · 2023-12-10T13:34:47Z

Binding for the smartlock TheKeys

[thekeys] Initial binding contribution

Description

This is the binding for TheKeys Smartlock.
This binding allows you to integrate, view, control and configure TheKeys Gateway and TheKeys Smartlock.

Full description of the binding capabilites in the README.md

Documentation

The logo is waiting this PR : openhab/openhab-docs#2171

Testing

The compiled jar bundle is available here : org.openhab.binding.thekeys-4.1.0-SNAPSHOT.jar

Binding for the smartlock TheKeys Signed-off-by: Jordan Martin <jo69270@gmail.com>

lolodomo · 2023-12-18T00:18:27Z

I will review your contribution.

Just reading the README, I have already a first comment: firmware version should be a thing property, not a channel.

JordanMartin · 2023-12-18T13:13:44Z

I removed the version channel and fix some typo in the readme

…o fix some doc typo Signed-off-by: Jordan Martin <jo69270@gmail.com>

Signed-off-by: Jordan Martin <jo69270@gmail.com>

lolodomo

Review part 1

bundles/org.openhab.binding.thekeys/README.md

...ding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/TheKeysBindingConstants.java

...hekeys/src/main/java/org/openhab/binding/thekeys/internal/gateway/TheKeysGatewayHandler.java

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysSmartlockHandler.java

.../src/main/java/org/openhab/binding/thekeys/internal/gateway/TheKeysGatewayConfiguration.java

lolodomo · 2023-12-18T19:10:59Z

Notes for myself, items example to be reviewed.

Signed-off-by: Jordan Martin <jo69270@gmail.com>

…perty Signed-off-by: Jordan Martin <jo69270@gmail.com>

Signed-off-by: Jordan Martin <jo69270@gmail.com>

lolodomo · 2023-12-18T23:54:56Z

You could have a look to compilation warnings. I see in particular several "Potential null pointer access".

I will review the remaining part (real java code) soon.

holgerfriedrich

Thanks for you contribution!
This is not a full review, just a few comments on code style.

Javadoc runs w/o errors (warnings are ok). i18n is fine.

A lot of Null warnings.

Do you know how the gateway could be discovered (apparently there is a smartphone app which can do)? Just asking, as we try to suggest add-ons for installation if the devices are detected.

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

...hekeys/src/main/java/org/openhab/binding/thekeys/internal/gateway/TheKeysGatewayHandler.java

bundles/org.openhab.binding.thekeys/README.md

clinique

Some minor comments.

bundles/org.openhab.binding.thekeys/pom.xml

...b.binding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/GatewayService.java

...ng.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/GatewayInfosDTO.java

....binding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/LockerDTO.java

...ng.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/LockerStatusDTO.java

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysSmartlockHandler.java

Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin · 2023-12-24T16:13:02Z

Thanks for you contribution! This is not a full review, just a few comments on code style.

Javadoc runs w/o errors (warnings are ok). i18n is fine.

A lot of Null warnings.

Do you know how the gateway could be discovered (apparently there is a smartphone app which can do)? Just asking, as we try to suggest add-ons for installation if the devices are detected.

As far as I know, it is not possible to discover the gateway on the network. It doesn't use mDNS nor uPNP.
It might be possible (not teseted) by using the remote api and the user account but I prefered to keep this binding only connected locally to the gateway.

lolodomo · 2023-12-28T10:37:25Z

Please update your last commit to add "Signed-off-by". I hope this is the only commit without it and leading a DCO being KO.

jlaur · 2023-12-28T10:43:14Z

Please update your last commit to add "Signed-off-by". I hope this is the only commit without it and leading a DCO being KO.

It is. If you click "Details" you can see that only one commit is missing the sign-off, and there are instructions how to fix it. @lolodomo, in such cases we can still merge, we just have to make sure to pick one of the correct sign-offs for the squash merge commit message.

lolodomo

Review of the api package.
Mainly exception handling to improve.

...b.binding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/GatewayService.java

...ng.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/LockerStatusDTO.java

...binding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/LockersDTO.java

...ng.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/LockerStatusDTO.java

...ing.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/model/SynchronizeDTO.java

lolodomo

Last comment about files in resources folder

bundles/org.openhab.binding.thekeys/src/main/resources/OH-INF/thing/thing-types.xml

lolodomo · 2023-12-28T12:24:17Z

Remains to review: 3 Java classes (thing handlers and discovery class) + the test class + the example in README.
I will try to finish today.

lolodomo · 2023-12-29T08:31:46Z

Mainly exception handling to improve.

The best option could be to catch different possible exceptions in your low level methods (get and post) and then rethrow only a TheKeysException.
Then you only have to consider TheKeysException in all calling methods.

bundles/org.openhab.binding.thekeys/README.md

J-N-K · 2024-01-02T21:33:57Z

...s/src/main/java/org/openhab/binding/thekeys/internal/provider/TheKeyTranslationProvider.java

+ * @author Jordan Martin - Initial contribution
+ */
+@NonNullByDefault
+@Component(service = TheKeyTranslationProvider.class)


With the latest changes in core you no longer need this.

J-N-K · 2024-01-02T21:35:26Z

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

+@NonNullByDefault
+public class TheKeysDiscoveryService extends AbstractDiscoveryService implements ThingHandlerService {
+
+ private final Logger logger = LoggerFactory.getLogger(TheKeysDiscoveryService.class);
+
+ @Nullable
+ private TheKeysGatewayHandler gatewayHandler;


Suggested change

@NonNullByDefault

public class TheKeysDiscoveryService extends AbstractDiscoveryService implements ThingHandlerService {

private final Logger logger = LoggerFactory.getLogger(TheKeysDiscoveryService.class);

@Nullable

private TheKeysGatewayHandler gatewayHandler;

@Component(scope = ServiceScope.PROTOTYPE, service = TheKeysDiscoveryService.class)

@NonNullByDefault

public class TheKeysDiscoveryService extends AbstractThingHandlerDiscoveryService<TheKeysGatewayHandler> {

private final Logger logger = LoggerFactory.getLogger(TheKeysDiscoveryService.class);

private final Bundle bundle;

J-N-K · 2024-01-02T21:35:46Z

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

+ private TheKeysGatewayHandler gatewayHandler;
+
+ public TheKeysDiscoveryService() {
+ super(Set.of(THING_TYPE_SMARTLOCK), 15, false);


Suggested change

super(Set.of(THING_TYPE_SMARTLOCK), 15, false);

super(TheKeysGatewayHandler.class, Set.of(THING_TYPE_SMARTLOCK), 15, false);

this.bundle = FrameworkUtil.getBundle(this.getClass());

J-N-K · 2024-01-02T21:36:57Z

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

+ TheKeysGatewayHandler gatewayHandler = Objects.requireNonNull(this.gatewayHandler);
+ ThingUID gatewayThingUID = gatewayHandler.getThing().getUID();
+ String label = gatewayHandler.getTranslationProvider().getText("discovery.thekeys.smartlock.label");


Suggested change

TheKeysGatewayHandler gatewayHandler = Objects.requireNonNull(this.gatewayHandler);

ThingUID gatewayThingUID = gatewayHandler.getThing().getUID();

String label = gatewayHandler.getTranslationProvider().getText("discovery.thekeys.smartlock.label");

ThingUID gatewayThingUID = thingHandler.getThing().getUID();

String label = thingHandler.getTranslationProvider().getText("discovery.thekeys.smartlock.label");

The thingHandler is now an implicit non-null field. You don't need null-checks.

J-N-K · 2024-01-02T21:37:25Z

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

+ TheKeysGatewayHandler gatewayHandler = Objects.requireNonNull(this.gatewayHandler);
+ ThingUID gatewayThingUID = gatewayHandler.getThing().getUID();


Suggested change

TheKeysGatewayHandler gatewayHandler = Objects.requireNonNull(this.gatewayHandler);

ThingUID gatewayThingUID = gatewayHandler.getThing().getUID();

ThingUID gatewayThingUID = thingHandler.getThing().getUID();

J-N-K · 2024-01-02T21:38:50Z

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

+
+ @Override
+ public @Nullable ThingHandler getThingHandler() {
+ return gatewayHandler;
+ }
+
+ @Override
+ public void setThingHandler(@Nullable ThingHandler handler) {
+ if (handler instanceof TheKeysGatewayHandler theKeysGatewayHandler) {
+ gatewayHandler = theKeysGatewayHandler;
+ }
+ }
+
+ @Override
+ public void deactivate() {
+ super.deactivate();
+ }


Suggested change

@Override

public @Nullable ThingHandler getThingHandler() {

return gatewayHandler;

}

@Override

public void setThingHandler(@Nullable ThingHandler handler) {

if (handler instanceof TheKeysGatewayHandler theKeysGatewayHandler) {

gatewayHandler = theKeysGatewayHandler;

}

}

@Override

public void deactivate() {

super.deactivate();

}

Not needed anymore, this is already provided by the super class.

J-N-K · 2024-01-02T21:47:40Z

...ys/src/main/java/org/openhab/binding/thekeys/internal/smartlock/TheKeysDiscoveryService.java

+ public TheKeysDiscoveryService() {
+ super(Set.of(THING_TYPE_SMARTLOCK), 15, false);
+ }
+


Suggested change

@Reference(unbind = "-")

public void bindTranslationProvider(TranslationProvider i18NProvider) {

this.i18NProvider = i18NProvider;

}

@Reference(unbind = "-")

public void bindLocaleProvider(LocaleProvider localeProvider) {

this.localeProvider = localeProvider;

}

public String getText(String key, @Nullable Object... arguments) {

try {

Locale locale = localeProvider.getLocale();

return i18nProvider.getText(bundle, key, getDefaultText(key), locale, arguments);

} catch (IllegalArgumentException e) {

return "Unable to load message for key " + key;

}

}

public @Nullable String getDefaultText(String key) {

return i18nProvider.getText(bundle, key, key, Locale.ENGLISH);

}

bundles/org.openhab.binding.thekeys/src/main/resources/OH-INF/thing/thing-types.xml

lolodomo · 2024-03-03T09:43:15Z

@JordanMartin : I thought I was very late but now I see that you have pushed nothing since we published our comments.

Please let the reviewers mark comments as resolved. This is difficult for us to follow what was really considered if you mark them as resolved even without providing any change.

I will finish the review if you are still working on this binding and you push new code.

Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin · 2024-03-29T09:55:27Z

@lolodomo I've done almost all the requested changes but I haven't had time to test it yet.
I will ensure that comments are appropriately addressed in future revisions,

lolodomo

Restart of the review

lolodomo · 2024-05-26T18:06:29Z

bundles/org.openhab.binding.thekeys/README.md

+| batteryLevel | Number:Power | R | Current battery level |
+| lowBattery | Switch | R | Low battery warning |


Real channel names are "battery-level" and "low-battery".

Type for battery-level is Number, not Number:Power.

lolodomo · 2024-05-26T18:07:50Z

bundles/org.openhab.binding.thekeys/README.md

+| syncInProgress | Switch | R | Indicates the pending update of the lock state |
+| lastSync | DateTime | R | Date of the last success sync with the lock |


Real channel names are "sync-in-progress" and "last-sync"

lolodomo · 2024-05-26T18:12:12Z

bundles/org.openhab.binding.thekeys/README.md

+| status | String | R | Status of the smartlock |
+| batteryLevel | Number:Power | R | Current battery level |
+| lowBattery | Switch | R | Low battery warning |
+| rssi | Number | R | Bluetooth signal strength with the gateway |


Type is Number:Power

lolodomo · 2024-05-26T18:14:41Z

bundles/org.openhab.binding.thekeys/README.md

+Number Smartlock_Battery_Level "Battery Level" <Battery> (Smartlock) ["Measurement", "Energy"] { channel="thekeys:smartlock:tk-gateway:1234:batteryLevel" } 
+Switch Smartlock_Low_Battery "Low Battery" <LowBattery> (Smartlock) ["Energy", "LowBattery"] { channel="thekeys:smartlock:tk-gateway:1234:lowBattery" } 


battery-level and low-battery for the channel ids

lolodomo · 2024-05-26T18:15:26Z

bundles/org.openhab.binding.thekeys/README.md

+Switch Smartlock_Synchronization_In_Progress "Synchronization In Progress" (Smartlock) ["Point"] { channel="thekeys:smartlock:tk-gateway:1234:syncInProgress" } 
+DateTime Smartlock_Last_Sync "Last Sync" (Smartlock) ["Point"] { channel="thekeys:smartlock:tk-gateway:1234:lastSync" } 


sync-in-progress and last-sync for the channel ids

lolodomo · 2024-05-26T18:23:47Z

bundles/org.openhab.binding.thekeys/src/main/resources/OH-INF/i18n/thekeys.properties

+channel-type.thekeys.lock_status.label = Lock Status
+channel-type.thekeys.lock_status.description = Status of the smartlock


Please regenerate the i18n files, they contain old names for channels.
mvn i18n:generate-default-translations

lolodomo · 2024-05-26T18:33:22Z

bundles/org.openhab.binding.thekeys/pom.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"


Look at in an existing POM file, these first 2 lines were slightly updated.

<?xml version="1.0" encoding="UTF-8" standalone="no"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

lolodomo · 2024-05-26T18:35:39Z

...ding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/TheKeysBindingConstants.java

+ public static final String CHANNEL_BATTERY_LEVEL = "batteryLevel";
+ public static final String CHANNEL_LOW_BATTERY = "lowBattery";


Real channel names are "battery-level" and "low-battery".

lolodomo · 2024-05-26T18:36:13Z

...ding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/TheKeysBindingConstants.java

+ public static final String CHANNEL_LAST_SYNC = "lastSync";
+ public static final String CHANNEL_SYNC_IN_PROGRESS = "syncInProgress";


Real channel names are "sync-in-progress" and "last-sync"

lolodomo · 2024-05-26T19:36:59Z

...inding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/TheKeysHttpClient.java

+ * @param url The target url
+ * @param timeoutMs The request timeout in ms
+ * @param responseType The type of the response to be parsed
+ * @return The parsed response or null if empty response


null cannot happen

lolodomo · 2024-05-26T19:37:10Z

...inding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/TheKeysHttpClient.java

+ * @param body The body to be posted
+ * @param timeout The request timeout in ms
+ * @param responseType The type of the response to be parsed
+ * @return The parsed response or null if empty response


null cannot happen

lolodomo · 2024-05-26T19:37:52Z

...inding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/TheKeysHttpClient.java

+ * @return The parsed response or null if empty response
+ * @throws TheKeysException If the request failed
+ */
+ public <T> T get(String url, int timeoutMs, Class<@NonNull T> responseType) throws TheKeysException {


@NonNull is useless as @NonNullByDefault is applied to your full class.

lolodomo · 2024-05-26T19:39:07Z

...inding.thekeys/src/main/java/org/openhab/binding/thekeys/internal/api/TheKeysHttpClient.java

+ * @return The parsed response or null if empty response
+ * @throws TheKeysException If the request failed
+ */
+ public <T> T post(String url, String body, int timeout, Class<T> responseType) throws TheKeysException {


Ultra minor: the parameter is timeout in that method while timeoutMs in the previous one. Suggestion (and not request for change): the naming could be consistent.

lolodomo · 2024-05-26T19:43:04Z

bundles/org.openhab.binding.thekeys/README.md

@@ -0,0 +1,101 @@
+# The Keys Binding
+
+This is the binding for [TheKeys Smartlock](https://www.the-keys.eu/en/produits/8-serrure-connectee.html).


Looks like https://www.the-keys.eu/ does not respond...

lolodomo · 2024-05-26T19:47:30Z

@JordanMartin : I restarted the review and added few new comments (that are easy to fix). I noticed that you already considered all my previous review comments, thank you for that. I will try to finish the full review during the coming week. If you are available to handle the last comments, we can probably conclude quickly.

lsiepel · 2024-06-28T15:11:48Z

Gentle ping @JordanMartin are you able to proceed?

lolodomo · 2024-06-29T08:35:26Z

I could finish the review but to not loose my free time, first I would like to have a comment from @JordanMartin to be sure he is still interested to finish this binding.

PS: I could even push changes that I recommend to speed up the process but in that case I could no more be the unique reviewer.

lsiepel · 2024-06-29T08:44:05Z

I could finish the review but to not loose my free time, first I would like to have a comment from @JordanMartin to be sure he is still interested to finish this binding.

PS: I could even push changes that I recommend to speed up the process but in that case I could no more be the unique reviewer.

I’ll be available to review. But a comment from @JordanMartin would be best as this binding hardly has a future if the contributor stops development before the initial PR is finished.

JordanMartin · 2024-07-08T22:41:12Z

My smart lock is broken.
I will not continue this binding because I cannot test anymore, and the brand has discontinued this product (without replacement).
Sorry for the delay and the useless work.

lsiepel · 2024-07-09T00:58:29Z

That is very unfortunate. Also very good that you shared this, it saves spending any more time on this matter. I’ll close this PR for now as there seems no base to continue.

JordanMartin requested a review from a team as a code owner December 10, 2023 13:34

JordanMartin mentioned this pull request Dec 10, 2023

Add logo for thekeys binding openhab/openhab-docs#2171

Draft

JordanMartin force-pushed the new-binding-thekeys branch from 71f9c80 to 7b1dde5 Compare December 10, 2023 13:45

[thekeys] Initial binding contribution

86061e9

Binding for the smartlock TheKeys Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin force-pushed the new-binding-thekeys branch from 7b1dde5 to 86061e9 Compare December 10, 2023 13:48

lolodomo added the new binding If someone has started to work on a binding. For a new binding PR. label Dec 10, 2023

lsiepel changed the title ~~[thekeys] Initial binding contribution~~ [thekeys] Initial contribution Dec 15, 2023

JordanMartin added 2 commits December 18, 2023 14:23

PR review : Remove firmware version channels and keep as property Als…

f819ae9

…o fix some doc typo Signed-off-by: Jordan Martin <jo69270@gmail.com>

Add error message status on fetch fail

b1deedf

Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin force-pushed the new-binding-thekeys branch from 7dbac76 to b1deedf Compare December 18, 2023 13:24

lolodomo requested changes Dec 18, 2023

View reviewed changes

JordanMartin added 6 commits December 18, 2023 20:56

PR review: Break line after each sentence in README.md

24be282

Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: clarify the setup part in README.md

2b0f644

Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: channels description

9014bbd

Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: use standard openhab firmwareVersion instead of custom pro…

99ac323

…perty Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: set default value in configuration class

4f08804

Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: many fix

1678465

Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin force-pushed the new-binding-thekeys branch from b395d0f to 1678465 Compare December 18, 2023 23:25

PR review: typo

df7ec75

Signed-off-by: Jordan Martin <jo69270@gmail.com>

holgerfriedrich requested changes Dec 21, 2023

View reviewed changes

clinique requested changes Dec 22, 2023

View reviewed changes

J-N-K mentioned this pull request Dec 24, 2023

Refactor ThingHandlerService to an OSGi component prototype openhab/openhab-core#3957

Merged

PR review: fix npe potential NPP and use record instead of class for DTO

51dd2b1

Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin force-pushed the new-binding-thekeys branch from 51a2958 to 51dd2b1 Compare December 24, 2023 15:48

JordanMartin requested a review from clinique December 24, 2023 16:16

JordanMartin requested review from holgerfriedrich and lolodomo December 24, 2023 16:16

lolodomo requested changes Dec 28, 2023

View reviewed changes

bundles/org.openhab.binding.thekeys/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved

J-N-K requested changes Jan 2, 2024

View reviewed changes

JordanMartin force-pushed the new-binding-thekeys branch from c2486f5 to 37ff24e Compare March 28, 2024 16:33

JordanMartin added 4 commits March 28, 2024 17:37

pom.xml: update parent to 4.2.0-SNAPSHOT

8e4eb2a

Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: fix typo

e6d6a60

Signed-off-by: Jordan Martin <jo69270@gmail.com>

PR review: change exception handle and some fix

e80d502

Signed-off-by: Jordan Martin <jo69270@gmail.com>

[thekeys] update file header

5697a13

Signed-off-by: Jordan Martin <jo69270@gmail.com>

JordanMartin force-pushed the new-binding-thekeys branch from 37ff24e to 5697a13 Compare March 28, 2024 20:41

lolodomo requested changes May 26, 2024

View reviewed changes

lolodomo reviewed May 26, 2024

View reviewed changes

lsiepel added the awaiting feedback label Jun 15, 2024

lsiepel closed this Jul 9, 2024

	super(Set.of(THING_TYPE_SMARTLOCK), 15, false);
	super(TheKeysGatewayHandler.class, Set.of(THING_TYPE_SMARTLOCK), 15, false);
	this.bundle = FrameworkUtil.getBundle(this.getClass());

		TheKeysGatewayHandler gatewayHandler = Objects.requireNonNull(this.gatewayHandler);
		ThingUID gatewayThingUID = gatewayHandler.getThing().getUID();

	TheKeysGatewayHandler gatewayHandler = Objects.requireNonNull(this.gatewayHandler);
	ThingUID gatewayThingUID = gatewayHandler.getThing().getUID();
	ThingUID gatewayThingUID = thingHandler.getThing().getUID();

+ @Reference(unbind = "-")
+ public void bindTranslationProvider(TranslationProvider i18NProvider) {
+ this.i18NProvider = i18NProvider;
+ }
+ @Reference(unbind = "-")
+ public void bindLocaleProvider(LocaleProvider localeProvider) {
+ this.localeProvider = localeProvider;
+ }
+ public String getText(String key, @Nullable Object... arguments) {
+ try {
+ Locale locale = localeProvider.getLocale();
+ return i18nProvider.getText(bundle, key, getDefaultText(key), locale, arguments);
+ } catch (IllegalArgumentException e) {
+ return "Unable to load message for key " + key;
+ }
+ }
+ public @Nullable String getDefaultText(String key) {
+ return i18nProvider.getText(bundle, key, key, Locale.ENGLISH);
+ }

		\| batteryLevel \| Number:Power \| R \| Current battery level \|
		\| lowBattery \| Switch \| R \| Low battery warning \|

		\| syncInProgress \| Switch \| R \| Indicates the pending update of the lock state \|
		\| lastSync \| DateTime \| R \| Date of the last success sync with the lock \|

		Number Smartlock_Battery_Level "Battery Level" <Battery> (Smartlock) ["Measurement", "Energy"] { channel="thekeys:smartlock:tk-gateway:1234:batteryLevel" }
		Switch Smartlock_Low_Battery "Low Battery" <LowBattery> (Smartlock) ["Energy", "LowBattery"] { channel="thekeys:smartlock:tk-gateway:1234:lowBattery" }

		Switch Smartlock_Synchronization_In_Progress "Synchronization In Progress" (Smartlock) ["Point"] { channel="thekeys:smartlock:tk-gateway:1234:syncInProgress" }
		DateTime Smartlock_Last_Sync "Last Sync" (Smartlock) ["Point"] { channel="thekeys:smartlock:tk-gateway:1234:lastSync" }

		channel-type.thekeys.lock_status.label = Lock Status
		channel-type.thekeys.lock_status.description = Status of the smartlock

		<?xml version="1.0" encoding="UTF-8"?>
		<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"

		public static final String CHANNEL_BATTERY_LEVEL = "batteryLevel";
		public static final String CHANNEL_LOW_BATTERY = "lowBattery";

		public static final String CHANNEL_LAST_SYNC = "lastSync";
		public static final String CHANNEL_SYNC_IN_PROGRESS = "syncInProgress";

		@@ -0,0 +1,101 @@
		# The Keys Binding

		This is the binding for [TheKeys Smartlock](https://www.the-keys.eu/en/produits/8-serrure-connectee.html).

[thekeys] Initial contribution #16037

[thekeys] Initial contribution #16037

Conversation

JordanMartin commented Dec 10, 2023 • edited Loading

Binding for the smartlock TheKeys

Description

Documentation

Testing

lolodomo commented Dec 18, 2023

JordanMartin commented Dec 18, 2023

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo commented Dec 18, 2023

lolodomo commented Dec 18, 2023 • edited Loading

holgerfriedrich left a comment • edited Loading

Choose a reason for hiding this comment

clinique left a comment

Choose a reason for hiding this comment

JordanMartin commented Dec 24, 2023

lolodomo commented Dec 28, 2023

jlaur commented Dec 28, 2023

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo commented Dec 28, 2023 • edited Loading

lolodomo commented Dec 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolodomo commented Mar 3, 2024

JordanMartin commented Mar 29, 2024

lolodomo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolodomo May 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolodomo commented May 26, 2024 • edited Loading

lsiepel commented Jun 28, 2024

lolodomo commented Jun 29, 2024

lsiepel commented Jun 29, 2024

JordanMartin commented Jul 8, 2024

lsiepel commented Jul 9, 2024

JordanMartin commented Dec 10, 2023 •

edited

Loading

lolodomo commented Dec 18, 2023 •

edited

Loading

holgerfriedrich left a comment •

edited

Loading

lolodomo commented Dec 28, 2023 •

edited

Loading

lolodomo May 26, 2024 •

edited

Loading

lolodomo commented May 26, 2024 •

edited

Loading