[modbus] Improve error message if data thing is configured for reading but not connected to a polling bridge. #16054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minichma
force-pushed
the
modbus_data_write_errormessage
branch
from
c72229d to
ef5c549
Compare
ssalonen
reviewed
Dec 13, 2023
...modbus/src/main/java/org/openhab/binding/modbus/internal/handler/ModbusDataThingHandler.java
Show resolved
Hide resolved
...modbus/src/main/java/org/openhab/binding/modbus/internal/handler/ModbusDataThingHandler.java
Outdated
Show resolved
Hide resolved
lolodomo
requested changes
Dec 14, 2023
...modbus/src/main/java/org/openhab/binding/modbus/internal/handler/ModbusDataThingHandler.java
Outdated
Show resolved
Hide resolved
…g but not connected to a polling bridge. Signed-off-by: Markus Minichmayr <markus@minichmayr.net>
minichma
force-pushed
the
modbus_data_write_errormessage
branch
from
ef5c549 to
1d75029
Compare
lolodomo
added
the
enhancement
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-1-milestone-discussion/149502/158 |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…g but not connected to a polling bridge. (openhab#16054) Signed-off-by: Markus Minichmayr <markus@minichmayr.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…g but not connected to a polling bridge. (openhab#16054) Signed-off-by: Markus Minichmayr <markus@minichmayr.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that a modbus
datathing can only be used for reading if it is connected to apollingbridge thing (rather than to a TCP or serial bridge thing), might not be obvious to every user. This PR improves the error message in case of a misconfiguration, i.e. if a thing is configured for reading but not connected to a polling bridge.