Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Ensure to close all scheduled jobs #16056

Merged
merged 3 commits into from
Dec 16, 2023
Merged

[netatmo] Ensure to close all scheduled jobs #16056

merged 3 commits into from
Dec 16, 2023

Conversation

clinique
Copy link
Contributor

This PR adresses an issue raised in #15928.
Some zombie job can remain if :

  • The bridge goes online and offline while inbetween one of its child scheduled to ask for data expiration
  • Refresh process did not kill the job on error and rescheduled it

@clinique
Close all jobs
2206e8c 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner December 13, 2023 16:31
@clinique clinique self-assigned this Dec 13, 2023
@clinique clinique added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Dec 13, 2023
@clinique
Small code refining
71187f6 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Correcting SAT error
6870293 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Copy link
Contributor Author

@lolodomo : if you want, you can review this one. I'm fine with it.

@clinique clinique removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Dec 15, 2023
lolodomo
lolodomo approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lolodomo lolodomo merged commit 7a1884d into openhab:main Dec 16, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Dec 16, 2023
@clinique clinique deleted the netatmo_15928_2 branch December 16, 2023 09:48
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@clinique @austvik
[netatmo] Ensure to close all scheduled jobs (openhab#16056)
7df8fd7 
* Close all jobs

---------

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@clinique @joni1993
[netatmo] Ensure to close all scheduled jobs (openhab#16056)
4da7515 
* Close all jobs

---------

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees

@clinique clinique

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@clinique @lolodomo