Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.espmilighthub] use ColorUtil instead of deprecated HSBType.fromXY #16066

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 15, 2023

and fix that it expects ranges from 0.0 to 1.0 instead of 0.0 to 100.0

this fixes the error:

2023-12-15 09:25:53.036 [WARN ] [nternal.handler.EspMilightHubHandler] - Failed processing Milight state {"state":"OFF","level":0,"color_temp":166,"bulb_mode":"white"} for milight/states/0x1757/fut089/3
java.lang.IllegalArgumentException: xy array only allows two or three values between 0.0 and 1.0.

and fix that it expects ranges from 0.0 to 1.0 instead of 0.0 to 100.0

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested a review from Skinah as a code owner December 15, 2023 16:49
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 15, 2023

@lolodomo this one is important to get in before 4.1 final. I've been running a custom firmware on my ESPMilightHub, and been having issues. I assumed the problem was a bug in my firmware that I needed to debug, but when I dug into this morning, I realized the firmware is fine, and updates weren't showing in openHAB because of this issue.

@ccutrer ccutrer added the bug An unexpected problem or unintended behavior of an add-on label Dec 15, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit cece5c5 into openhab:main Dec 15, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Dec 15, 2023
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 15, 2023

Thank you!

@ccutrer ccutrer deleted the mqtt-espmilighthub-colorutil branch December 15, 2023 18:51
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…XY (openhab#16066)

and fix that it expects ranges from 0.0 to 1.0 instead of 0.0 to 100.0

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…XY (openhab#16066)

and fix that it expects ranges from 0.0 to 1.0 instead of 0.0 to 100.0

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants