Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Addon info for suggestions #16090

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

holgerfriedrich
Copy link
Member

Allow addon suggestion finders to send a discovery message to multicast address.
Requires openhab/openhab-core#3943

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@Skinah
Copy link
Contributor

Skinah commented Dec 26, 2023

LGTM thank you for adding this.

@holgerfriedrich holgerfriedrich added enhancement An enhancement or new feature for an existing add-on and removed work in progress A PR that is not yet ready to be merged awaiting other PR Depends on another PR labels Feb 14, 2024
@holgerfriedrich
Copy link
Member Author

openhab/openhab-core#3943 is merged, we could continue with this one

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 779d1c5 into openhab:main Feb 16, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Feb 16, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [ipcamera] Addon info for suggestions

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@holgerfriedrich holgerfriedrich deleted the pr-ipcamera branch July 27, 2024 13:23
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [ipcamera] Addon info for suggestions

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants