Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Fix stack overflow, sensor init on wakeup and wrong temp channel for Plus 1 #16240

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[shelly] Fix stack overflow, sensor init on wakeup and wrong temp channel for Plus 1 #16240

merged 1 commit into from
Jan 18, 2024

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Jan 8, 2024 •
edited
Loading

Fixes https://community.openhab.org/t/oh-4-1-stackoverflow-shellybinding/152478/7 identified by @wborn as well as sensor initialization on wakeup, missing temperature5 description; missing relay definition for shellywalldisplay; Some README fixes

Closing
#16236
#16207
#16140
#15982

@markus7017
Fix stack overflow when an unknown CoAP Id is detected; Fix innerTemp
9960649 
channel creation for Gen2 devices not having this; Fix sensor
initialization on wakeup; Fix missingf temperature5 description; add
missing relay definition for shellywalldisplay; Some README fixes
@markus7017 markus7017 added the bug An unexpected problem or unintended behavior of an add-on label Jan 8, 2024
@markus7017 markus7017 self-assigned this Jan 8, 2024
@markus7017 markus7017 requested a review from lolodomo January 8, 2024 01:27
@markus7017 markus7017 mentioned this pull request Jan 8, 2024
Closed
lsiepel
lsiepel approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel
Copy link
Contributor

lsiepel commented Jan 16, 2024 •
edited
Loading

Could you fix the DCO?
For future fixes, it would be great if multiple fixes can be split PR per fix/subject. This would make changes small, isolated, enables simple backport if needed and they all end up in the release notes on their own.

@markus7017
Copy link
Contributor Author

markus7017 commented Jan 18, 2024 •
edited
Loading

@lsiepel done

I recommend a backport for this PR. Is there a label I could mark this?

@lsiepel lsiepel merged commit a6f9adf into openhab:main Jan 18, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jan 18, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Jan 18, 2024

kport for this PR. Is there a label I could mark this?

Give me a couple of days, don't have much time to spare and have to check how this is done.

@lsiepel lsiepel changed the title [shelly] FIx stack overflow, sensor init on wakeup, wrong temp channel for Plus 1; README fixes [shelly] Fix stack overflow, sensor init on wakeup and wrong temp channel for Plus 1 Jan 18, 2024
@lsiepel lsiepel self-assigned this Jan 18, 2024
@jlaur
Copy link
Contributor

jlaur commented Jan 18, 2024

kport for this PR. Is there a label I could mark this?

Give me a couple of days, don't have much time to spare and have to check how this is done.

Perhaps you can verify with this summary I once wrote: #15329 (comment)

@lsiepel
Copy link
Contributor

lsiepel commented Jan 18, 2024

kport for this PR. Is there a label I could mark this?

Give me a couple of days, don't have much time to spare and have to check how this is done.

Perhaps you can verify with this summary I once wrote: #15329 (comment)

Thanks, will check it. Very funny, that was a regression of my own 'fix' :-/

lsiepel pushed a commit that referenced this pull request Jan 18, 2024
@markus7017 @lsiepel
Fix stack overflow when an unknown CoAP Id is detected; Fix innerTemp (…
5556646 
…#16240)

channel creation for Gen2 devices not having this; Fix sensor
initialization on wakeup; Fix missingf temperature5 description; add
missing relay definition for shellywalldisplay; Some README fixes
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Jan 18, 2024
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
@markus7017 @andrasU
Fix stack overflow when an unknown CoAP Id is detected; Fix innerTemp (…
a65028d 
…openhab#16240)

channel creation for Gen2 devices not having this; Fix sensor
initialization on wakeup; Fix missingf temperature5 description; add
missing relay definition for shellywalldisplay; Some README fixes

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@markus7017 @austvik
Fix stack overflow when an unknown CoAP Id is detected; Fix innerTemp (…
632de90 
…openhab#16240)

channel creation for Gen2 devices not having this; Fix sensor
initialization on wakeup; Fix missingf temperature5 description; add
missing relay definition for shellywalldisplay; Some README fixes

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@markus7017 @joni1993
Fix stack overflow when an unknown CoAP Id is detected; Fix innerTemp (…
5169bc5 
…openhab#16240)

channel creation for Gen2 devices not having this; Fix sensor
initialization on wakeup; Fix missingf temperature5 description; add
missing relay definition for shellywalldisplay; Some README fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo

Assignees

@markus7017 markus7017

@lsiepel lsiepel

Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@markus7017 @lsiepel @jlaur