-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network] Add configuration parameter for using iOS wake-up #16259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Jan 11, 2024
radoslavv
reviewed
Jan 12, 2024
....network/src/main/java/org/openhab/binding/network/internal/NetworkHandlerConfiguration.java
Outdated
Show resolved
Hide resolved
wborn
reviewed
Jan 12, 2024
bundles/org.openhab.binding.network/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
wborn
reviewed
Jan 12, 2024
bundles/org.openhab.binding.network/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Jan 12, 2024
bundles/org.openhab.binding.network/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
wborn
changed the title
[network] Make assumption iOs device configurable
[network] Add configuration parameter for using iOS wake-up
Jan 15, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
wborn
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 27, 2024
…16259) Fixes openhab#9575 Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…16259) Fixes openhab#9575 Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…16259) Fixes openhab#9575 Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme previously stated it did auto detection of iOs device, but to me it seemed hardcoded. I changed this to a configurable option as some IoT devices can't handle the additional port knocking.
Test jar 4.2.0: https://1drv.ms/u/s!AnMcxmvEeupwjuUA88rQxWnsCUkymg?e=xXOno9