-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[knx] postUpdate for contact-control sends to bus #16263
[knx] postUpdate for contact-control sends to bus #16263
Conversation
Not sure if this is the most elegant way to solve the problem. |
05ccdf3
to
4b0918d
Compare
4b0918d
to
0521b5c
Compare
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device. * Add a new profile for contact-control items * Add a profile factory and a profile advisor class * Handle postUpdate like a command and send message on KNX bus Fixes openhab#16115. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
0521b5c
to
7845a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow looks like a huge workaround, but I wouldn't have any better suggestion how to address the issue.
@J-N-K Any thoughts from your side? Shall we merge it like this?
I don't know any better implementation. I think openhab/openhab-core#2578 is a similar issue where we need a solution for sending something in to the outside world that is only acceptation updates, not commands. My suggestion would be to merge here and discuss the " |
Thanks for your input - so let's merge then! |
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device. * Add a new profile for contact-control items * Add a profile factory and a profile advisor class * Handle postUpdate like a command and send message on KNX bus Fixes openhab#16115. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Should this PR probably get backported to 4.1.x? |
Since 4.2 is around the corner, I don't think we will do another 4.1.x patch release. |
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device. * Add a new profile for contact-control items * Add a profile factory and a profile advisor class * Handle postUpdate like a command and send message on KNX bus Fixes openhab#16115. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
contact-control items need to send to the bus like a switch item, to trigger a state update in the external device.
Fixes #16115.