Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] postUpdate for contact-control sends to bus #16263

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

holgerfriedrich
Copy link
Member

contact-control items need to send to the bus like a switch item, to trigger a state update in the external device.

  • Add a new profile for contact-control items
  • Add a profile factory and a profile advisor class
  • Handle postUpdate like a command and send message on KNX bus

Fixes #16115.

@holgerfriedrich
Copy link
Member Author

Not sure if this is the most elegant way to solve the problem.
Until now only tested postUpdate().

@holgerfriedrich holgerfriedrich added the bug An unexpected problem or unintended behavior of an add-on label Jan 12, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow looks like a huge workaround, but I wouldn't have any better suggestion how to address the issue.
@J-N-K Any thoughts from your side? Shall we merge it like this?

@J-N-K
Copy link
Member

J-N-K commented Jan 27, 2024

I don't know any better implementation. I think openhab/openhab-core#2578 is a similar issue where we need a solution for sending something in to the outside world that is only acceptation updates, not commands. My suggestion would be to merge here and discuss the "OpenClosedType / RawType / ... can't be send" issue somewhere else.

@kaikreuzer
Copy link
Member

Thanks for your input - so let's merge then!

@kaikreuzer kaikreuzer merged commit d5fc695 into openhab:main Jan 28, 2024
3 checks passed
@holgerfriedrich holgerfriedrich deleted the pr-knx-contact-control branch January 28, 2024 21:19
@lsiepel lsiepel added this to the 4.2 milestone Feb 17, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@florian-h05
Copy link
Contributor

Should this PR probably get backported to 4.1.x?

@kaikreuzer
Copy link
Member

Since 4.2 is around the corner, I don't think we will do another 4.1.x patch release.

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
contact-control items need to send to the bus like a switch item,
to trigger a state update in the external device.

* Add a new profile for contact-control items
* Add a profile factory and a profile advisor class
* Handle postUpdate like a command and send message on KNX bus

Fixes openhab#16115.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[knx] OH 4.1.0 KNX binding fails to send updates to contact-control items
5 participants