Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pollytts] Update Apache httpcore and httpclient #16294

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

morph166955
Copy link
Contributor

@morph166955 morph166955 commented Jan 16, 2024

Updates Apache httpcore and httpclient to resolve dependencies.

Resolves #16293

Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
@morph166955
Copy link
Contributor Author

@J-N-K opening this as draft while we figure out what to do with IPP and IHC

@J-N-K
Copy link
Member

J-N-K commented Jan 16, 2024

I think upgrading to client/4.5.14 and core/4.4.13 should be safe, I did look at the release notes and there are no breaking changes as far as I can see.

@morph166955
Copy link
Contributor Author

morph166955 commented Jan 16, 2024

Sounds good. Would it be smarter to just pull this back to the main addons pom to include since it crossed multiple bindings? Or even maybe back to core? That should help us keep it up to date across.

@wborn wborn changed the title Update Apache httpcore and httpclient [pollytts] Update Apache httpcore and httpclient Jan 22, 2024
@morph166955 morph166955 marked this pull request as ready for review March 4, 2024 22:50
@morph166955 morph166955 requested a review from a team as a code owner March 4, 2024 22:50
@morph166955
Copy link
Contributor Author

Is this good to merge at this point? I'm still getting the same error on 3964

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on what i have seen this is ok to merge now.

@lsiepel lsiepel merged commit 9bcb338 into openhab:main Apr 30, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Apr 30, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old version of Apache http client throwing warning at start
3 participants