[netatmo] Fix erroneous local URL handling #16492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
…resence) so they remain reachable if API answer is in an incorrect network Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
|
This is a corner case. It does not happen all time (yesterday all day, this evening a part of my work session) where the vpnUrl returned by the API is not on the local network (http://169.254.xxx instead of http://192.168.xxxxx). The other option was to use the vpn url as a fallback - losing ability of actions (e.g. lights on/off) that requires local access. |
jlaur
changed the title
lolodomo
requested changes
Mar 10, 2024
...g.netatmo/src/main/java/org/openhab/binding/netatmo/internal/config/CameraConfiguration.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/OH-INF/config/config.xml
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/netatmo/internal/handler/capability/CameraCapability.java
Outdated
Show resolved
Hide resolved
Doing a bit a cleansing. I know it is not bug directly connected to bug correction but when I see some opportunities to enhance code... Signed-off-by: clinique <gael@lhopital.org>
…guration is not up-to-date Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
This was referenced Mar 19, 2024
clinique
added a commit
to clinique/openhab-addons
that referenced
this pull request
Mar 19, 2024
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
jlaur
pushed a commit
to jlaur/openhab-addons
that referenced
this pull request
Mar 23, 2024
* Wrong local URL handling * Adds configuration element ipAddress to Cameras (Welcome, Doorbell, Presence) so they remain reachable if API answer is in an incorrect network * Removing CameraConfiguration so binding does not break if thing configuration is not up-to-date --------- Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: gael@lhopital.org <gael@lhopital.org>
jlaur
pushed a commit
to jlaur/openhab-addons
that referenced
this pull request
Mar 23, 2024
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: gael@lhopital.org <gael@lhopital.org>
magx2
pushed a commit
to magx2/openhab2-addons
that referenced
this pull request
Mar 24, 2024
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: gael@lhopital.org <gael@lhopital.org>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28 |
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* Wrong local URL handling * Adds configuration element ipAddress to Cameras (Welcome, Doorbell, Presence) so they remain reachable if API answer is in an incorrect network * Removing CameraConfiguration so binding does not break if thing configuration is not up-to-date --------- Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Wrong local URL handling * Adds configuration element ipAddress to Cameras (Welcome, Doorbell, Presence) so they remain reachable if API answer is in an incorrect network * Removing CameraConfiguration so binding does not break if thing configuration is not up-to-date --------- Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: gael@lhopital.org <gael@lhopital.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: gael@lhopital.org <gael@lhopital.org>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: gael@lhopital.org <gael@lhopital.org>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating issue #15883 I identified this issue.
I has also hit HA other extensions the same way.