-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PJLinkDevice] audio/video mute #16504
Conversation
5997a22
to
7c428ea
Compare
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
Tested successfully using the PJLinkTEST4CNT application. Ready to be reviewed 🙂 |
As you add a new channel, please provide upgrade instructions. |
Do you have an example of what needs to be considered for an upgrade when adding a channel? |
It is documented in details ... but I don't find the page anymore! |
bundles/org.openhab.binding.pjlinkdevice/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Gentel ping @nils do you need anything to proceed? |
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@lsiepel : thank you for finishing the job. Build is failing. |
* audio/video mute Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Co-authored-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>
* audio/video mute Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Co-authored-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* audio/video mute Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Co-authored-by: Leo Siepel <leosiepel@gmail.com>
* audio/video mute Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Co-authored-by: Leo Siepel <leosiepel@gmail.com>
As requested on the community.